Skip to content
This repository was archived by the owner on Sep 6, 2019. It is now read-only.

Commit cfb4085

Browse files
scttcperpatrickmichalina
authored andcommitted
feat: update angulartics2 to v4.0.0 (#303)
1 parent 0ff94d8 commit cfb4085

13 files changed

+39
-29
lines changed

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@
147147
"@ngx-meta/core": "^4.0.1",
148148
"angular2-jwt": "^0.2.3",
149149
"angularfire2": "^5.0.0-rc.3",
150-
"angulartics2": "3.3.0",
150+
"angulartics2": "4.0.0",
151151
"body-parser": "^1.18.2",
152152
"bunyan-middleware": "^0.8.0",
153153
"clean-css": "^4.1.9",

src/client/app/+account/account.component.html

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div *ngIf="user$ | async as user" class="flex-center">
22
<h2>{{ user.displayName }}</h2>
33
<a class="flex-center">
4-
<img *ngIf="user.photoURL" [src]="user.photoURL" class="avatar" angulartics2On="mouseover" angularticsEvent="HoveredOverAccountProfileImage">
4+
<img *ngIf="user.photoURL" [src]="user.photoURL" class="avatar" angulartics2On="mouseover" angularticsAction="HoveredOverAccountProfileImage">
55
<a mat-button>Update Photo</a>
66
</a>
77
<mat-accordion class="headers-align">
@@ -17,20 +17,20 @@ <h2>{{ user.displayName }}</h2>
1717
<form [formGroup]="detailForm" (ngSubmit)="updateDetail()">
1818
<mat-form-field>
1919
<input matInput formControlName="displayName" [value]="user.displayName" type="text" placeholder="Name" angulartics2On="focus"
20-
angularticsEvent="FocusedOnAccountDisplayNameInput">
20+
angularticsAction="FocusedOnAccountDisplayNameInput">
2121
</mat-form-field>
2222
<mat-form-field>
23-
<input matInput formControlName="email" type="email" [value]="user.email" placeholder="Email" angulartics2On="focus" angularticsEvent="FocusedOnAccountEmailInput">
23+
<input matInput formControlName="email" type="email" [value]="user.email" placeholder="Email" angulartics2On="focus" angularticsAction="FocusedOnAccountEmailInput">
2424
<!-- <mat-icon matSuffix [matTooltip]="user.emailTooltip" [color]="user.emailColor" fontSet="fa" [fontIcon]="user.emailIcon" angulartics2On="mouseover"
25-
angularticsEvent="HoveredOverAccountEmailCheckmarkIcon"></mat-icon> -->
25+
angularticsAction="HoveredOverAccountEmailCheckmarkIcon"></mat-icon> -->
2626
</mat-form-field>
2727
<mat-form-field>
2828
<input matInput formControlName="phoneNumber" type="text" [value]="user.phone || ''" placeholder="Phone" angulartics2On="focus"
29-
angularticsEvent="FocusedOnAccountPhonenumberInput">
29+
angularticsAction="FocusedOnAccountPhonenumberInput">
3030
</mat-form-field>
31-
<button mat-raised-button type="submit"
31+
<button mat-raised-button type="submit"
3232
[disabled]="!detailForm.dirty"
33-
color="primary" id="update-btn" angulartics2On="input" angulartics2On="click" angularticsEvent="ClickUpdateProfile">Save Changes</button>
33+
color="primary" id="update-btn" angulartics2On="input" angulartics2On="click" angularticsAction="ClickUpdateProfile">Save Changes</button>
3434
</form>
3535
</mat-expansion-panel>
3636
<mat-expansion-panel disabled=true #socialPanel>
@@ -83,20 +83,20 @@ <h2>{{ user.displayName }}</h2>
8383
</mat-expansion-panel-header>
8484
<form [formGroup]="passForm" (ngSubmit)="updatePassword()">
8585
<mat-form-field>
86-
<input matInput formControlName="currentPassword" type="password" placeholder="Current Password" angulartics2On="focus" angularticsEvent="FocusedOnAccountPasswordChangeInput">
86+
<input matInput formControlName="currentPassword" type="password" placeholder="Current Password" angulartics2On="focus" angularticsAction="FocusedOnAccountPasswordChangeInput">
8787
<mat-error *ngIf="passForm.controls.currentPassword.hasError('required')">
8888
<strong>required</strong>
8989
</mat-error>
9090
</mat-form-field>
9191
<mat-form-field>
92-
<input matInput formControlName="newPassword" type="password" placeholder="New Password" angulartics2On="focus" angularticsEvent="FocusedOnAccountPasswordChangeInput">
92+
<input matInput formControlName="newPassword" type="password" placeholder="New Password" angulartics2On="focus" angularticsAction="FocusedOnAccountPasswordChangeInput">
9393
<mat-error *ngIf="passForm.controls.newPassword.hasError('required')">
9494
<strong>required</strong>
9595
</mat-error>
9696
</mat-form-field>
9797
<button mat-raised-button [disabled]="passForm.invalid" type="submit" color="primary" id="update-btn" angulartics2On="input"
98-
angulartics2On="click" angularticsEvent="ClickUpdateProfile">Save Changes</button>
98+
angulartics2On="click" angularticsAction="ClickUpdateProfile">Save Changes</button>
9999
</form>
100100
</mat-expansion-panel>
101101
</mat-accordion>
102-
</div>
102+
</div>

src/client/app/+home/__snapshots__/home.component.spec.ts.snap

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ exports[`HomeComponent should compile 1`] = `
3030
3131
<a
3232
angulartics2on="click"
33-
angularticsevent="ViewRepo"
33+
angularticsaction="ViewRepo"
3434
class="mat-raised-button"
3535
color="primary"
3636
href="https://github.com/patrickmichalina/fusebox-angular-universal-starter"
@@ -113,5 +113,6 @@ exports[`HomeComponent should compile 1`] = `
113113
114114
115115
</mat-card>
116+
116117
</pm-home>
117118
`;

src/client/app/+home/home.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<h1 class="display-3">Hello, Angular Developer!</h1>
44
<p class="lead">Welcome to a blazing fast Angular Universal development starter</p>
55
<a mat-raised-button color="primary" href="https://github.com/patrickmichalina/fusebox-angular-universal-starter" role="button"
6-
angulartics2On="click" angularticsEvent="ViewRepo">
6+
angulartics2On="click" angularticsAction="ViewRepo">
77
<mat-icon class="fa fa-github" aria-hidden="true"></mat-icon> Github</a>
88
</div>
99
<mat-tab-group>
@@ -85,4 +85,4 @@ <h1 class="display-3">Hello, Angular Developer!</h1>
8585
</ul>
8686
</mat-tab>
8787
</mat-tab-group>
88-
</mat-card>
88+
</mat-card>

src/client/app/+home/home.component.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { By } from '@angular/platform-browser'
22
import { RouterTestingModule } from '@angular/router/testing'
3-
import { Angulartics2, Angulartics2GoogleAnalytics, Angulartics2Module } from 'angulartics2'
3+
import { Angulartics2, Angulartics2Module } from 'angulartics2'
4+
import { Angulartics2GoogleAnalytics } from 'angulartics2/ga'
45
import { HomeComponent } from './home.component'
56
import { async, ComponentFixture, TestBed } from '@angular/core/testing'
67
import { Component } from '@angular/core'

src/client/app/app.component.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import { SharedModule } from './shared/shared.module'
1212
import { EnvConfig } from '../../../tools/config/app.config'
1313
import { ENV_CONFIG } from './app.config'
1414
import { EnvironmentService } from './shared/services/environment.service'
15-
import { Angulartics2GoogleAnalytics, Angulartics2Module } from 'angulartics2'
15+
import { Angulartics2Module } from 'angulartics2'
16+
import { Angulartics2GoogleAnalytics } from 'angulartics2/ga'
1617
import { HttpClientTestingModule } from '@angular/common/http/testing'
1718
import { NavbarService } from './shared/navbar/navbar.service'
1819
import { MatCardModule } from '@angular/material'

src/client/app/app.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { HttpClient } from '@angular/common/http'
88
import { WebSocketService } from './shared/services/web-socket.service'
99
import { DOCUMENT, TransferState } from '@angular/platform-browser'
1010
import { SettingService } from './shared/services/setting.service'
11-
import { Angulartics2GoogleAnalytics } from 'angulartics2'
11+
import { Angulartics2GoogleAnalytics } from 'angulartics2/ga'
1212
import { MatIconRegistry, MatSidenav, MatSlideToggle } from '@angular/material'
1313
import { ActivatedRoute, NavigationEnd, Router } from '@angular/router'
1414
import { InjectionService } from './shared/services/injection.service'

src/client/app/app.module.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import { NotFoundModule } from './not-found/not-found.module'
99
import { BrowserModule, makeStateKey } from '@angular/platform-browser'
1010
import { EnvironmentService } from './shared/services/environment.service'
1111
import { ServerResponseService } from './shared/services/server-response.service'
12-
import { Angulartics2GoogleAnalytics, Angulartics2Module } from 'angulartics2'
12+
import { Angulartics2Module } from 'angulartics2'
13+
import { Angulartics2GoogleAnalytics } from 'angulartics2/ga'
1314
import { HTTP_INTERCEPTORS, HttpClientModule, HttpResponse } from '@angular/common/http'
1415
import { GlobalErrorHandler } from './shared/services/error-handler.service'
1516
import { SettingService } from './shared/services/setting.service'

src/client/app/not-found/not-found.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { FormControl, FormGroup, Validators } from '@angular/forms'
88
import { ServerResponseService } from './../shared/services/server-response.service'
99
import { ActivatedRoute, Router } from '@angular/router'
1010
import { Observable } from 'rxjs/Observable'
11+
import { filter } from 'rxjs/operators'
1112
import { SEONode, SEOService } from '../shared/services/seo.service'
1213
import { MatChipInputEvent, MatDialog, MatSnackBar } from '@angular/material'
1314
import { ModalConfirmationComponent } from '../shared/modal-confirmation/modal-confirmation.component'
@@ -128,7 +129,7 @@ export class NotFoundComponent {
128129
.map(a => a.tab ? +a.tab : 0)
129130

130131
private url$ = Observable.of(this.router.url.split('?')[0])
131-
.filter(a => !a.includes('.'))
132+
.pipe(filter(a => !a.includes('.')))
132133
.shareReplay()
133134

134135
public settingsForm = new FormGroup({

src/client/app/shared/navbar/__snapshots__/navbar.component.spec.ts.snap

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ exports[`NavbarComponent should compile 1`] = `
1212
1313
<button
1414
angulartics2on="click"
15-
angularticsevent="ToggleSideMenu"
15+
angularticsaction="ToggleSideMenu"
1616
class="mat-icon-button"
1717
id="toggle-menu-button"
1818
mat-icon-button=""
@@ -208,6 +208,8 @@ exports[`NavbarComponent should compile 1`] = `
208208
209209
210210
</nav>
211+
212+
211213
</div>
212214
`;
213215

@@ -223,7 +225,7 @@ exports[`NavbarComponent should contain a list of links 1`] = `
223225
224226
<button
225227
angulartics2on="click"
226-
angularticsevent="ToggleSideMenu"
228+
angularticsaction="ToggleSideMenu"
227229
class="mat-icon-button"
228230
id="toggle-menu-button"
229231
mat-icon-button=""
@@ -419,5 +421,7 @@ exports[`NavbarComponent should contain a list of links 1`] = `
419421
420422
421423
</nav>
424+
425+
422426
</div>
423427
`;

src/client/app/shared/navbar/navbar.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<nav class="mat-elevation-z6">
2-
<button id="toggle-menu-button" mat-icon-button (click)="onMenuIconClick.next()" angulartics2On="click" angularticsEvent="ToggleSideMenu">
2+
<button id="toggle-menu-button" mat-icon-button (click)="onMenuIconClick.next()" angulartics2On="click" angularticsAction="ToggleSideMenu">
33
<mat-icon fontSet="fa" fontIcon="fa-bars"></mat-icon>
44
</button>
55
<a class="nav-button" mat-button routerLink>FB-ANGULAR-UNIVERSAL-STARTER</a>
@@ -32,4 +32,4 @@ <h4>{{ user.email }}</h4>
3232
</button>
3333
</div>
3434
</mat-menu>
35-
</nav>
35+
</nav>

src/client/app/shared/shared.module.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import { EnvironmentService } from './services/environment.service'
1212
import { COOKIE_HOST_WHITELIST } from './services/http-cookie-interceptor.service'
1313
import { ENV_CONFIG } from '../app.config'
1414
import { NavbarService } from './navbar/navbar.service'
15-
import { Angulartics2GoogleAnalytics, Angulartics2Module } from 'angulartics2'
15+
import { Angulartics2Module } from 'angulartics2'
16+
import { Angulartics2GoogleAnalytics } from 'angulartics2/ga'
1617
import { MaterialModule } from './material.module'
1718
import { ClickOutsideDirective } from './directives/click-outside.directive'
1819
import { SocialButtonDirective } from './directives/social-button.directive'
@@ -74,7 +75,7 @@ export function loggerConfigFactory(ps: PlatformService, gooogleAnalytics: Angul
7475
FormsModule,
7576
ReactiveFormsModule,
7677
MarkdownToHtmlModule,
77-
Angulartics2Module.forChild(),
78+
Angulartics2Module,
7879
FlexLayoutModule
7980
],
8081
exports: [

0 commit comments

Comments
 (0)