Skip to content

jsDestructuringNoise should include commas inside array destructuring #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tandrewnichols opened this issue Apr 16, 2019 · 1 comment
Closed

Comments

@tandrewnichols
Copy link

I'm messing around with overriding some highlight groups and I'm noticing that jsDestructuringBraces does include array destructuring symbols ([ and ]), which is fine, but jsDestructuringNoise only includes , for object destructuring and not array destructuring.

E.g. if I do

HiLink jsDestructuringBraces Delimiter
HiLink jsDestructuringNoise Delimiter

Then

function({ foo, bar }) {

}

has the braces and commas highlighted as "delimiter" but in

function([ foo, bar ]) {

}

only the brackets are highlighted and not the comma. Small thing really since they're marked as "noise" by default, but it seems like they should be the same.

@amadeus
Copy link
Collaborator

amadeus commented Apr 16, 2019

Good catch! Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants