From fac82d6f110aaba1791273682c198fa70f79bed5 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Thu, 13 Feb 2025 14:54:46 -0800 Subject: [PATCH 1/2] TST: Update numpy version check for test_pandas_dtype_numpy_warning --- pandas/core/dtypes/common.py | 2 +- pandas/tests/dtypes/test_common.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/core/dtypes/common.py b/pandas/core/dtypes/common.py index e8881ff014a0c..e92f2363b69f1 100644 --- a/pandas/core/dtypes/common.py +++ b/pandas/core/dtypes/common.py @@ -1836,7 +1836,7 @@ def pandas_dtype(dtype) -> DtypeObj: # raise a consistent TypeError if failed try: with warnings.catch_warnings(): - # TODO: warnings.catch_warnings can be removed when numpy>2.2.2 + # TODO: warnings.catch_warnings can be removed when numpy>2.3.0 # is the minimum version # GH#51523 - Series.astype(np.integer) doesn't show # numpy deprecation warning of np.integer diff --git a/pandas/tests/dtypes/test_common.py b/pandas/tests/dtypes/test_common.py index 2bda2fddec2ff..57b63069cf3d9 100644 --- a/pandas/tests/dtypes/test_common.py +++ b/pandas/tests/dtypes/test_common.py @@ -789,7 +789,7 @@ def test_validate_allhashable(): def test_pandas_dtype_numpy_warning(): # GH#51523 - if Version(np.__version__) <= Version("2.2.2"): + if Version(np.__version__) <= Version("2.3.0"): ctx = tm.assert_produces_warning( DeprecationWarning, check_stacklevel=False, From 419a63001b0c26cf683e9c2b8dffb8d943ac3256 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Thu, 13 Feb 2025 15:15:23 -0800 Subject: [PATCH 2/2] less than the dev version --- pandas/tests/dtypes/test_common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/dtypes/test_common.py b/pandas/tests/dtypes/test_common.py index 57b63069cf3d9..d30fa9fc2ea0f 100644 --- a/pandas/tests/dtypes/test_common.py +++ b/pandas/tests/dtypes/test_common.py @@ -789,7 +789,7 @@ def test_validate_allhashable(): def test_pandas_dtype_numpy_warning(): # GH#51523 - if Version(np.__version__) <= Version("2.3.0"): + if Version(np.__version__) < Version("2.3.0.dev0"): ctx = tm.assert_produces_warning( DeprecationWarning, check_stacklevel=False,