From bc827eab76f79a4d9cbe69d4c6ded19fda385bc9 Mon Sep 17 00:00:00 2001 From: Sergio Livi Date: Fri, 9 Aug 2024 09:43:50 +0000 Subject: [PATCH 1/2] Use bash as default shell in Dockerfile --- .devcontainer.json | 1 - Dockerfile | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.devcontainer.json b/.devcontainer.json index 7c5d009260c64..54ddfa1a130f8 100644 --- a/.devcontainer.json +++ b/.devcontainer.json @@ -8,7 +8,6 @@ // Use 'settings' to set *default* container specific settings.json values on container create. // You can edit these settings after create using File > Preferences > Settings > Remote. "settings": { - "terminal.integrated.shell.linux": "/bin/bash", "python.pythonPath": "/usr/local/bin/python", "python.formatting.provider": "black", "python.linting.enabled": true, diff --git a/Dockerfile b/Dockerfile index 0fcbcee92295c..5a15a82964510 100644 --- a/Dockerfile +++ b/Dockerfile @@ -12,4 +12,6 @@ RUN python -m pip install --upgrade pip COPY requirements-dev.txt /tmp RUN python -m pip install -r /tmp/requirements-dev.txt RUN git config --global --add safe.directory /home/pandas + +ENV SHELL "/bin/bash" CMD ["/bin/bash"] From d5bbd97345cd8a02d09a7e1e1d5353cb6a0dafe3 Mon Sep 17 00:00:00 2001 From: Sergio Livi Date: Fri, 9 Aug 2024 10:45:09 +0000 Subject: [PATCH 2/2] Add --install-hooks in pre-commit and bash-completion in Dockerfile --- .gitpod.yml | 2 +- Dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitpod.yml b/.gitpod.yml index 9222639136a17..9ff349747a33e 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -14,7 +14,7 @@ tasks: cp gitpod/settings.json .vscode/settings.json git fetch --tags python -m pip install -ve . --no-build-isolation --config-settings editable-verbose=true - pre-commit install + pre-commit install --install-hooks command: | python -m pip install -ve . --no-build-isolation --config-settings editable-verbose=true echo "✨ Pre-build complete! You can close this terminal ✨ " diff --git a/Dockerfile b/Dockerfile index 5a15a82964510..dead3a494e52d 100644 --- a/Dockerfile +++ b/Dockerfile @@ -2,7 +2,7 @@ FROM python:3.10.8 WORKDIR /home/pandas RUN apt-get update && apt-get -y upgrade -RUN apt-get install -y build-essential +RUN apt-get install -y build-essential bash-completion # hdf5 needed for pytables installation # libgles2-mesa needed for pytest-qt