BUG: Implement fillna(..., limit=x) for EAs #58249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
commented
Apr 13, 2024
pandas/core/arrays/base.py
Outdated
| @@ -1073,6 +1066,12 @@ def fillna( | |||
| Length: 6, dtype: Int64 | |||
| """ | |||
| mask = self.isna() | |||
| if limit is not None and limit < len(self): | |||
| modify = mask.cumsum() > limit | |||
There was a problem hiding this comment.
self.isna() can return an ExtensionArray, which may not implement cumsum because we don't require it to implement _accumulate (but do require _reduce). Would it be okay to require _accumulate? Still not sure about the comparison > in that case.
There was a problem hiding this comment.
@jbrockmendel - any thoughts here?
There was a problem hiding this comment.
I’d be fine with that. Could add a comment to that effect
rhshadrach
commented
Apr 13, 2024
| @@ -149,6 +149,16 @@ def test_fillna_frame(self): | |||
| """We treat dictionaries as a mapping in fillna, not a scalar.""" | |||
| super().test_fillna_frame() | |||
|
|
|||
| @pytest.mark.xfail(reason="fill value is a dictionary, takes incorrect code path") | |||
There was a problem hiding this comment.
We cannot use fillna with JSONArray because DataFrame.fillna has special logic for dict / Series argument.
rhshadrach
added
Bug
Missing-data
mroeschke
reviewed
May 3, 2024
mroeschke
approved these changes
May 3, 2024
|
Thanks @rhshadrach |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* BUG: Implement fillna(..., limit=x) for EAs * Comments * type ignores * Update doc/source/whatsnew/v3.0.0.rst --------- Co-authored-by: Matthew Roeschke <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fillna(..., limit=x)for EAs #58001 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.