BUG: Remove "Mean of empty slice" warning in nanmedian #58107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supresses a warning when calculating the
median
of apd.Series
that is full ofNA
s. The warning is just letting you know thatnumpy
got an empty array but correctly returnsnp.nan
.The warning is issued as follows:
NA
s and you try to calculate themedian
,nanops.nanmedian
is called._mask
innanops.nanmedian.get_median
is allFalse
, sonp.nanmedian(x[_mask])
gets an empty array.np.nanmedian
callsnumpy.lib.nanfunctions._nanmedian
which has a short-circuit path when the array is empty [ref].np.nanmean
. This creates an empty mask [ref] because the array is empty.mean
, which causes the result to benp.nan
(correct!).Another way to solve this would be to change
get_median
to explicitly returnnp.nan
before the call tonp.nanmedian
, but that would involve tampering with the condition in the if, which has no comments so I'm unsure if changing it makes sense.which simplifies to
if skipna: return np.nan
I think.I haven't added tests nor ensured all of the below passed not added comments because I want to ensure this is the preferred solution. Otherwise, I can edit
get_median
. Let me know!doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.