DOC: update link in benchmarks.md #57903
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web/pandas/community/benchmarks.md
Outdated
| @@ -75,5 +75,5 @@ There is a quick summary here: | |||
|
|
|||
| The main benchmarks comparing dataframe tools that include pandas are: | |||
|
|
|||
| - [H2O.ai benchmarks](https://h2oai.github.io/db-benchmark/) | |||
| - [DuckDB benchmarks](https://duckdblabs.github.io/db-benchmark/) | |||
There was a problem hiding this comment.
I think it'd be good to mention that those were the former H20.ai benchmarks. Maybe something as simple as this:
Suggested change
| - [DuckDB benchmarks](https://duckdblabs.github.io/db-benchmark/) | |
| - [DuckDB (former H20.ai) benchmarks](https://duckdblabs.github.io/db-benchmark/) |
There was a problem hiding this comment.
Sounds good. Thanks for your suggestion.
|
/preview |
|
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/57903/ |
|
Thank you @yukikitayama, very nice! |
|
Thanks for your review @datapythonista 👍 |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The H20.ai benchmark link in the benchmarks webpage contains the outdated benchmark results (e.g. the last benchmark was performed July 2021 and it used the pandas==1.2.5). DuckDB published a new benchmark results (e.g. the last benchmark was December 2023 with pandas==2.1.1) in the link with the same approach described in their blog. So it's a good idea to replace the benchmark link. Thank you @rootsmusic for the issue.