From 63a56cba7d135cf7b7419d7a043393e3b7abd02c Mon Sep 17 00:00:00 2001 From: Natalia Mokeeva Date: Tue, 20 Feb 2024 12:43:12 +0100 Subject: [PATCH 1/2] fix mypy failures in pandas/core/generic.py --- pandas/core/generic.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pandas/core/generic.py b/pandas/core/generic.py index 946bf99e7c9ae..b8f89852a7083 100644 --- a/pandas/core/generic.py +++ b/pandas/core/generic.py @@ -6460,7 +6460,7 @@ def copy(self, deep: bool | None = True) -> Self: 1 [3, 4] dtype: object """ - data = self._mgr.copy(deep=deep) + data = self._mgr.copy(deep=deep) # type: ignore[arg-type] return self._constructor_from_mgr(data, axes=data.axes).__finalize__( self, method="copy" ) @@ -7451,7 +7451,7 @@ def replace( if items: keys, values = zip(*items) else: - keys, values = ([], []) # type: ignore[assignment] + keys, values = ([], []) are_mappings = [is_dict_like(v) for v in values] @@ -7468,7 +7468,7 @@ def replace( for k, v in items: # error: Incompatible types in assignment (expression has type # "list[Never]", variable has type "tuple[Any, ...]") - keys, values = list(zip(*v.items())) or ( # type: ignore[assignment] + keys, values = list(zip(*v.items())) or ( [], [], ) From 27b05fc54246a1dbea3987e295f57c6ff5454632 Mon Sep 17 00:00:00 2001 From: Natalia Mokeeva Date: Tue, 20 Feb 2024 14:47:16 +0100 Subject: [PATCH 2/2] move back my changes in line 7454, 7471 --- pandas/core/generic.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/core/generic.py b/pandas/core/generic.py index b8f89852a7083..bc5f6b2733b99 100644 --- a/pandas/core/generic.py +++ b/pandas/core/generic.py @@ -7451,7 +7451,7 @@ def replace( if items: keys, values = zip(*items) else: - keys, values = ([], []) + keys, values = ([], []) # type: ignore[assignment] are_mappings = [is_dict_like(v) for v in values] @@ -7468,7 +7468,7 @@ def replace( for k, v in items: # error: Incompatible types in assignment (expression has type # "list[Never]", variable has type "tuple[Any, ...]") - keys, values = list(zip(*v.items())) or ( + keys, values = list(zip(*v.items())) or ( # type: ignore[assignment] [], [], )