From d496e2ce5e0feb7ce2949d69079b48ddac89866d Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Thu, 1 Feb 2024 11:56:42 -0800 Subject: [PATCH 1/5] CLN: Remove old coverage branches and ignored warnings --- pyproject.toml | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 96e8ea90afa59..b5a12c0a04b54 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -253,8 +253,8 @@ ignore = [ # "W503", # not yet implemented # line break after binary operator # "W504", # not yet implemented - # controversial - "B006", + # # controversial + # "B006", # controversial "B007", # controversial @@ -498,20 +498,8 @@ filterwarnings = [ "ignore::ResourceWarning:asyncio", # From plotting doctests "ignore:More than 20 figures have been opened:RuntimeWarning", - # Will be fixed in numba 0.56: https://github.com/numba/numba/issues/7758 - "ignore:`np.MachAr` is deprecated:DeprecationWarning:numba", - "ignore:.*urllib3:DeprecationWarning:botocore", - "ignore:Setuptools is replacing distutils.:UserWarning:_distutils_hack", # https://github.com/PyTables/PyTables/issues/822 "ignore:a closed node found in the registry:UserWarning:tables", - "ignore:`np.object` is a deprecated:DeprecationWarning:tables", - "ignore:tostring:DeprecationWarning:tables", - "ignore:distutils Version classes are deprecated:DeprecationWarning:pandas_datareader", - "ignore:distutils Version classes are deprecated:DeprecationWarning:numexpr", - "ignore:distutils Version classes are deprecated:DeprecationWarning:fastparquet", - "ignore:distutils Version classes are deprecated:DeprecationWarning:fsspec", - # Can be removed once https://github.com/numpy/numpy/pull/24794 is merged - "ignore:.*In the future `np.long` will be defined as.*:FutureWarning", ] junit_family = "xunit2" markers = [ @@ -775,14 +763,11 @@ exclude_lines = [ "pragma: no cover", # Don't complain about missing debug-only code:s "def __repr__", - "if self.debug", # Don't complain if tests don't hit defensive assertion code: "raise AssertionError", "raise NotImplementedError", "AbstractMethodError", # Don't complain if non-runnable code isn't run: - "if 0:", - "if __name__ == .__main__.:", "if TYPE_CHECKING:", ] From 29b66bae15b2d306cc6a49f00d94c4677d29d78f Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Thu, 1 Feb 2024 11:56:48 -0800 Subject: [PATCH 2/5] CLN: Remove old coverage branches and ignored warnings --- scripts/tests/data/deps_minimum.toml | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/tests/data/deps_minimum.toml b/scripts/tests/data/deps_minimum.toml index 0424920e5f446..ca1dc0c961c42 100644 --- a/scripts/tests/data/deps_minimum.toml +++ b/scripts/tests/data/deps_minimum.toml @@ -494,14 +494,11 @@ exclude_lines = [ "pragma: no cover", # Don't complain about missing debug-only code:s "def __repr__", - "if self.debug", # Don't complain if tests don't hit defensive assertion code: "raise AssertionError", "raise NotImplementedError", "AbstractMethodError", # Don't complain if non-runnable code isn't run: - "if 0:", - "if __name__ == .__main__.:", "if TYPE_CHECKING:", ] From 572ca28c75ff07227d220f626dfcfbfbd035137b Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Thu, 1 Feb 2024 11:57:46 -0800 Subject: [PATCH 3/5] Undo comment out --- pyproject.toml | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index b5a12c0a04b54..96e8ea90afa59 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -253,8 +253,8 @@ ignore = [ # "W503", # not yet implemented # line break after binary operator # "W504", # not yet implemented - # # controversial - # "B006", + # controversial + "B006", # controversial "B007", # controversial @@ -498,8 +498,20 @@ filterwarnings = [ "ignore::ResourceWarning:asyncio", # From plotting doctests "ignore:More than 20 figures have been opened:RuntimeWarning", + # Will be fixed in numba 0.56: https://github.com/numba/numba/issues/7758 + "ignore:`np.MachAr` is deprecated:DeprecationWarning:numba", + "ignore:.*urllib3:DeprecationWarning:botocore", + "ignore:Setuptools is replacing distutils.:UserWarning:_distutils_hack", # https://github.com/PyTables/PyTables/issues/822 "ignore:a closed node found in the registry:UserWarning:tables", + "ignore:`np.object` is a deprecated:DeprecationWarning:tables", + "ignore:tostring:DeprecationWarning:tables", + "ignore:distutils Version classes are deprecated:DeprecationWarning:pandas_datareader", + "ignore:distutils Version classes are deprecated:DeprecationWarning:numexpr", + "ignore:distutils Version classes are deprecated:DeprecationWarning:fastparquet", + "ignore:distutils Version classes are deprecated:DeprecationWarning:fsspec", + # Can be removed once https://github.com/numpy/numpy/pull/24794 is merged + "ignore:.*In the future `np.long` will be defined as.*:FutureWarning", ] junit_family = "xunit2" markers = [ @@ -763,11 +775,14 @@ exclude_lines = [ "pragma: no cover", # Don't complain about missing debug-only code:s "def __repr__", + "if self.debug", # Don't complain if tests don't hit defensive assertion code: "raise AssertionError", "raise NotImplementedError", "AbstractMethodError", # Don't complain if non-runnable code isn't run: + "if 0:", + "if __name__ == .__main__.:", "if TYPE_CHECKING:", ] From a0f09a3a414952880da6db93ba3c4dc8f1f21416 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Thu, 1 Feb 2024 14:00:57 -0800 Subject: [PATCH 4/5] Test removing warnings --- pyproject.toml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 96e8ea90afa59..a362c7fc82cb2 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -498,20 +498,8 @@ filterwarnings = [ "ignore::ResourceWarning:asyncio", # From plotting doctests "ignore:More than 20 figures have been opened:RuntimeWarning", - # Will be fixed in numba 0.56: https://github.com/numba/numba/issues/7758 - "ignore:`np.MachAr` is deprecated:DeprecationWarning:numba", - "ignore:.*urllib3:DeprecationWarning:botocore", - "ignore:Setuptools is replacing distutils.:UserWarning:_distutils_hack", # https://github.com/PyTables/PyTables/issues/822 "ignore:a closed node found in the registry:UserWarning:tables", - "ignore:`np.object` is a deprecated:DeprecationWarning:tables", - "ignore:tostring:DeprecationWarning:tables", - "ignore:distutils Version classes are deprecated:DeprecationWarning:pandas_datareader", - "ignore:distutils Version classes are deprecated:DeprecationWarning:numexpr", - "ignore:distutils Version classes are deprecated:DeprecationWarning:fastparquet", - "ignore:distutils Version classes are deprecated:DeprecationWarning:fsspec", - # Can be removed once https://github.com/numpy/numpy/pull/24794 is merged - "ignore:.*In the future `np.long` will be defined as.*:FutureWarning", ] junit_family = "xunit2" markers = [ From 06945b4c73eb9cc5967e8021a50a61ad6dcaced2 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Thu, 1 Feb 2024 16:41:41 -0800 Subject: [PATCH 5/5] Add back some ignores --- pyproject.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pyproject.toml b/pyproject.toml index a362c7fc82cb2..d9e5b89b0f141 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -498,6 +498,8 @@ filterwarnings = [ "ignore::ResourceWarning:asyncio", # From plotting doctests "ignore:More than 20 figures have been opened:RuntimeWarning", + "ignore:.*urllib3:DeprecationWarning:botocore", + "ignore:Setuptools is replacing distutils.:UserWarning:_distutils_hack", # https://github.com/PyTables/PyTables/issues/822 "ignore:a closed node found in the registry:UserWarning:tables", ]