BUG: Replaced ValueError exception with TypeError exception in df.where() function #56495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function Replaced ValueError exception with TypeError as it is more appropriate for the error it serves.
|
You have to adjust one more test here: https://github.com/pandas-dev/pandas/blob/main/pandas/tests/series/indexing/test_where.py#L204 |
Thank you so much! Finally passed the checks! |
mroeschke
reviewed
Dec 18, 2023
|
mroeschke
reviewed
Jan 15, 2024
doc/source/whatsnew/v2.2.0.rst
Outdated
| @@ -896,6 +896,7 @@ Other | |||
| - Bug in :meth:`DataFrame.apply` where passing ``raw=True`` ignored ``args`` passed to the applied function (:issue:`55009`) | |||
| - Bug in :meth:`DataFrame.from_dict` which would always sort the rows of the created :class:`DataFrame`. (:issue:`55683`) | |||
| - Bug in :meth:`DataFrame.sort_index` when passing ``axis="columns"`` and ``ignore_index=True`` raising a ``ValueError`` (:issue:`56478`) | |||
| - Bug in :meth:`DataFrame.where()` where using a non-bool type array in the function would return a ``ValueError`` instead of a ``TypeError`` (:issue:`56330`) | |||
There was a problem hiding this comment.
Could you move this to v3.0.0.rst?
mroeschke
reviewed
Jan 16, 2024
mroeschke
reviewed
Jan 16, 2024
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
approved these changes
Jan 16, 2024
|
Thanks @DarthKitten2130 |
3 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…re() function (pandas-dev#56495) * Replaced ValueError exception with TypeError exception in df.where() function Replaced ValueError exception with TypeError as it is more appropriate for the error it serves. * Updated test_where.py to account for updated exceptions. * Update test_indexing.py to account for modified exceptions * Update test_where.py for series * Added bug fix to v2.2.0.rst * Updated v2.2.0.rst * Updated v2.2.0.rst * Updated v2.2.0.rst * Updated v2.2.0.rst * Updated v2.2.0.rst * resolved merge conflict * resolved conflicts again * Updated v2.2.0.rst * Updated v2.2.0.rst * removed change from 2.20 * Update v2.3.0.rst * Update doc/source/whatsnew/v2.3.0.rst Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced ValueError exception with TypeError as it is more appropriate for the error it serves
[] closes issue #56330 where there was a consensus that a TypeError is more appropriate for the following error: "Boolean array expected for the condition, not (non-bool type)". Since ValueErrors are raised when the type is correct but the value is incorrect, whereas in this function we are raising an exception because of a wrong type, hence the TypeError.
I've also included commits to update the tests for this method.
(I had already made this PR but messed up my commits because I'm new to GitHub so I'm redoing it).