From 64c4afb232f2f640769def2f91f9d25aaf8905fb Mon Sep 17 00:00:00 2001 From: Gabriel Kabbe Date: Wed, 19 Apr 2023 23:20:21 +0200 Subject: [PATCH 1/3] Add test for pyarrow date32 repr --- pandas/tests/extension/test_arrow.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pandas/tests/extension/test_arrow.py b/pandas/tests/extension/test_arrow.py index 25e643f53f925..dcb1d535e6046 100644 --- a/pandas/tests/extension/test_arrow.py +++ b/pandas/tests/extension/test_arrow.py @@ -2567,3 +2567,9 @@ def test_quantile_temporal(pa_type): result = ser.quantile(0.1) expected = ser[0] assert result == expected + +def test_date32_repr(): + # GH48238 + arrow_dt = pa.array([date.fromisoformat('2020-01-01')], type=pa.date32()) + ser = pd.Series(arrow_dt, dtype=pd.ArrowDtype(arrow_dt.type)) + assert repr(ser) From 47c8acb48012014bdff114eac1c974bb0acdd2bd Mon Sep 17 00:00:00 2001 From: Gabriel Kabbe Date: Thu, 20 Apr 2023 22:32:02 +0200 Subject: [PATCH 2/3] Use ArrowDtype directly --- pandas/tests/extension/test_arrow.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pandas/tests/extension/test_arrow.py b/pandas/tests/extension/test_arrow.py index dcb1d535e6046..766c1a7fe29a0 100644 --- a/pandas/tests/extension/test_arrow.py +++ b/pandas/tests/extension/test_arrow.py @@ -2568,8 +2568,9 @@ def test_quantile_temporal(pa_type): expected = ser[0] assert result == expected + def test_date32_repr(): # GH48238 - arrow_dt = pa.array([date.fromisoformat('2020-01-01')], type=pa.date32()) - ser = pd.Series(arrow_dt, dtype=pd.ArrowDtype(arrow_dt.type)) + arrow_dt = pa.array([date.fromisoformat("2020-01-01")], type=pa.date32()) + ser = pd.Series(arrow_dt, dtype=ArrowDtype(arrow_dt.type)) assert repr(ser) From 24ba641ca1ca2a180ae0533185e11a918d2f35c2 Mon Sep 17 00:00:00 2001 From: Gabriel Kabbe Date: Fri, 21 Apr 2023 11:10:42 +0200 Subject: [PATCH 3/3] Explicitly check the repr output --- pandas/tests/extension/test_arrow.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/extension/test_arrow.py b/pandas/tests/extension/test_arrow.py index 766c1a7fe29a0..88346a4d9b490 100644 --- a/pandas/tests/extension/test_arrow.py +++ b/pandas/tests/extension/test_arrow.py @@ -2573,4 +2573,4 @@ def test_date32_repr(): # GH48238 arrow_dt = pa.array([date.fromisoformat("2020-01-01")], type=pa.date32()) ser = pd.Series(arrow_dt, dtype=ArrowDtype(arrow_dt.type)) - assert repr(ser) + assert repr(ser) == "0 2020-01-01\ndtype: date32[day][pyarrow]"