From 1fb1cee8fb7fd52fdfa930bcc7f6e12efd40e156 Mon Sep 17 00:00:00 2001 From: GrammatikakisDimitris Date: Mon, 10 Apr 2023 12:16:55 +0000 Subject: [PATCH 1/4] Add test for MultiIndex.from_tuples --- pandas/tests/indexing/multiindex/test_multiindex.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pandas/tests/indexing/multiindex/test_multiindex.py b/pandas/tests/indexing/multiindex/test_multiindex.py index 8e507212976ec..60067a5c99810 100644 --- a/pandas/tests/indexing/multiindex/test_multiindex.py +++ b/pandas/tests/indexing/multiindex/test_multiindex.py @@ -206,3 +206,8 @@ def test_multiindex_with_na_missing_key(self): ) with pytest.raises(KeyError, match="missing_key"): df[[("missing_key",)]] + + def test_multiindex_from_tuples_with_nan(self): + # GH#23578 + multi_idx = MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")]) + assert isinstance(multi_idx, MultiIndex) From b33101fe325faeee98ad817ce3f7c7d675bef18a Mon Sep 17 00:00:00 2001 From: GrammatikakisDimitris Date: Mon, 10 Apr 2023 20:25:48 +0000 Subject: [PATCH 2/4] Make changes in test_multiindex_from_tuples --- pandas/tests/indexing/multiindex/test_multiindex.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pandas/tests/indexing/multiindex/test_multiindex.py b/pandas/tests/indexing/multiindex/test_multiindex.py index 60067a5c99810..694bdbc25081e 100644 --- a/pandas/tests/indexing/multiindex/test_multiindex.py +++ b/pandas/tests/indexing/multiindex/test_multiindex.py @@ -209,5 +209,6 @@ def test_multiindex_with_na_missing_key(self): def test_multiindex_from_tuples_with_nan(self): # GH#23578 - multi_idx = MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")]) - assert isinstance(multi_idx, MultiIndex) + result = MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")]) + expected = MultiIndex.from_tuples([("a", "b", "c"), (np.nan, np.nan, np.nan), ("d", "", "")]) + tm.assert_index_equal_result, expected From c86d75e997ad5b788bd4598bbbd51ece9cd1c80c Mon Sep 17 00:00:00 2001 From: GrammatikakisDimitris Date: Mon, 10 Apr 2023 20:38:10 +0000 Subject: [PATCH 3/4] Fix code check errors --- pandas/tests/indexing/multiindex/test_multiindex.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pandas/tests/indexing/multiindex/test_multiindex.py b/pandas/tests/indexing/multiindex/test_multiindex.py index 694bdbc25081e..fea31d35d0891 100644 --- a/pandas/tests/indexing/multiindex/test_multiindex.py +++ b/pandas/tests/indexing/multiindex/test_multiindex.py @@ -209,6 +209,8 @@ def test_multiindex_with_na_missing_key(self): def test_multiindex_from_tuples_with_nan(self): # GH#23578 - result = MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")]) - expected = MultiIndex.from_tuples([("a", "b", "c"), (np.nan, np.nan, np.nan), ("d", "", "")]) + MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")]) + expected = MultiIndex.from_tuples( + [("a", "b", "c"), (np.nan, np.nan, np.nan), ("d", "", "")] + ) tm.assert_index_equal_result, expected From 64bcac22e4858880bb5ea8d2b3c8d827efc4a95d Mon Sep 17 00:00:00 2001 From: GrammatikakisDimitris Date: Mon, 10 Apr 2023 22:58:09 +0000 Subject: [PATCH 4/4] Fix code style --- pandas/tests/indexing/multiindex/test_multiindex.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/tests/indexing/multiindex/test_multiindex.py b/pandas/tests/indexing/multiindex/test_multiindex.py index fea31d35d0891..d7285f0069c71 100644 --- a/pandas/tests/indexing/multiindex/test_multiindex.py +++ b/pandas/tests/indexing/multiindex/test_multiindex.py @@ -209,8 +209,8 @@ def test_multiindex_with_na_missing_key(self): def test_multiindex_from_tuples_with_nan(self): # GH#23578 - MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")]) + result = MultiIndex.from_tuples([("a", "b", "c"), np.nan, ("d", "", "")]) expected = MultiIndex.from_tuples( [("a", "b", "c"), (np.nan, np.nan, np.nan), ("d", "", "")] ) - tm.assert_index_equal_result, expected + tm.assert_index_equal(result, expected)