Skip to content

PERF: dtype checks #52506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2023
Merged

PERF: dtype checks #52506

merged 1 commit into from
Apr 7, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

mroeschke
mroeschke reviewed Apr 7, 2023
View reviewed changes
pandas/core/dtypes/missing.py
# datetime64, timedelta64, Period
if not is_dtype_equal(left.dtype, right.dtype):
if left.dtype != right.dtype:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we couldn't do this for np dtypes until we bumped our min version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cant do it for comparing numpy dtypes to EA dtypes, but this is safe in places where we have both numpy dtypes

@mroeschke mroeschke added the Performance Memory or execution speed performance label Apr 7, 2023
@mroeschke mroeschke added this to the 2.1 milestone Apr 7, 2023
@mroeschke mroeschke merged commit 8e19396 into pandas-dev:main Apr 7, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the perf-array_equivalent branch April 7, 2023 20:17
@jbrockmendel jbrockmendel mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Performance Memory or execution speed performance
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke