API: Series/DataFrame from empty dict should have RangeIndex #52426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
reviewed
Apr 5, 2023
Comment on lines
168
to
169
| expected = Index(keys, dtype="object", tupleize_cols=False) | ||
| expected = Index(keys, tupleize_cols=False) if keys else RangeIndex(0) |
There was a problem hiding this comment.
any chance we could include this in the parametrisation, instead of introducing an if-else in the test?
There was a problem hiding this comment.
Yes, that would be better.
| expected.index = expected.index.astype(float) | ||
| expected = empty_series.reset_index(drop=True) | ||
| if orient in ("split"): | ||
| expected.index = expected.index.astype(np.float64) |
There was a problem hiding this comment.
any reason to change float to np.float64? (not an issue, just trying to understand)
There was a problem hiding this comment.
No reason, my fingers must have liked np.float64 better than float in this case :-)
Comment on lines
+116
to
+123
| def test_empty_constructor(self, constructor, empty_index): | ||
| # GH 49573 (addition of empty_index parameter) | ||
| expected = Series(index=empty_index) | ||
| result = constructor(empty_index) | ||
|
|
||
| assert result.dtype == object | ||
| assert len(result.index) == 0 | ||
| tm.assert_series_equal(result, expected, check_index_type=check_index_type) | ||
| tm.assert_series_equal(result, expected, check_index_type=True) |
There was a problem hiding this comment.
nice, lovely simplification here!
MarcoGorelli
reviewed
Apr 5, 2023
| [ | ||
| ({}, [], "index"), | ||
| ([{("a",): 1}, {("a",): 2}], [("a",)], "columns"), | ||
| ([OrderedDict([(("a",), 1), (("b",), 2)])], [("a",), ("b",)], "columns"), |
There was a problem hiding this comment.
what happened to the ordereddict test case?
There was a problem hiding this comment.
Yeah, I've added it back in.
mroeschke
approved these changes
Apr 6, 2023
|
Small ping. |
|
Thanks @topper-123 |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 10, 2023
…hould have RangeIndex
mroeschke
pushed a commit
that referenced
this pull request
Apr 10, 2023
…dict should have RangeIndex) (#52578) Backport PR #52426: API: Series/DataFrame from empty dict should have RangeIndex Co-authored-by: Terji Petersen <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.