Skip to content

BUG: Series.any and Series.all for empty or all-null pyarrow-backed dtypes #51631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2023
Merged

BUG: Series.any and Series.all for empty or all-null pyarrow-backed dtypes #51631

merged 4 commits into from
Feb 25, 2023

Conversation

lukemanley
Copy link
Member

@lukemanley lukemanley added Bug Arrow pyarrow functionality labels Feb 25, 2023
phofl
phofl reviewed Feb 25, 2023
View reviewed changes
doc/source/whatsnew/v2.1.0.rst Outdated
@@ -198,7 +198,7 @@ Sparse

ExtensionArray
^^^^^^^^^^^^^^
-
- Bug in :meth:`Series.any` and :meth:`Series.all` for empty or all null pyarrow-backed dtypes (:issue:`51624`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what the bug was? Had to run an example to understand it. Otherwise lgtm

phofl
phofl approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mroeschke mroeschke added this to the 2.1 milestone Feb 25, 2023
@mroeschke mroeschke merged commit 4700a61 into pandas-dev:main Feb 25, 2023
@mroeschke
Copy link
Member

Thanks @lukemanley

@phofl phofl modified the milestones: 2.1, 2.0 Mar 15, 2023
@phofl
Copy link
Member

phofl commented Mar 15, 2023

back porting as well, because we need it for the other pr

@phofl
Copy link
Member

phofl commented Mar 15, 2023

@meeseeksdev backport 2.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented Mar 15, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4700a6101e6338fec437ed1222b9f827b4f66cd5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #51631: BUG: Series.any and Series.all for empty or all-null pyarrow-backed dtypes'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-51631-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #51631 on branch 2.0.x (BUG: Series.any and Series.all for empty or all-null pyarrow-backed dtypes)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

phofl pushed a commit to phofl/pandas that referenced this pull request Mar 15, 2023
@lukemanley @phofl
BUG: Series.any and Series.all for empty or all-null pyarrow-backed d…
a4b2c3a 
…types (pandas-dev#51631)

* BUG: ArrowExtensionArray boolean reductions for empty or all null array

* whatsnew

* clarify whatsnew
phofl pushed a commit to phofl/pandas that referenced this pull request Mar 15, 2023
@lukemanley @phofl
BUG: Series.any and Series.all for empty or all-null pyarrow-backed d…
d02aa49 
…types (pandas-dev#51631)

* BUG: ArrowExtensionArray boolean reductions for empty or all null array

* whatsnew

* clarify whatsnew
@phofl phofl mentioned this pull request Mar 15, 2023
Merged
@lukemanley lukemanley mentioned this pull request Mar 15, 2023
Merged
1 task
phofl added a commit that referenced this pull request Mar 15, 2023
@phofl @lukemanley
Backport PR #51631 on branch 2.0.x (BUG: Series.any and Series.all fo…
8daa913 
…r empty or all-null pyarrow-backed dtypes) (#51999)



Co-authored-by: Luke Manley <[email protected]>
@lukemanley lukemanley deleted the arrow-boolean-reduce branch March 17, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Bug
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG?: Series.any / Series.all behavior for pyarrow vs. non-pyarrow empty/all-NA
3 participants
@lukemanley @mroeschke @phofl