TST/CI/BUG: fix borked call to read_html testing code #5151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -619,6 +616,21 @@ def test_fallback_success(self): | |||
| self.read_html(banklist_data, '.*Water.*', flavor=['lxml', | |||
| 'html5lib']) | |||
|
|
|||
| def test_parse_dates_list(self): | |||
There was a problem hiding this comment.
What is this code? Rebase needed?
There was a problem hiding this comment.
Nope. I just copy-pasted the test from the bs4 test class over to the lxml version....I think you might be misunderstanding git rebase...
There was a problem hiding this comment.
No. Was correct use of rebase. If you had created new branch for this PR and then committed on top of a branch with work in progress.
e.g. A -> B -> C (origin/master) ->D (wip) -> E (cpcloud:read-html-lxml-skips)
you would want to rebase cpcloud:read-html-lxml-skips without commit D.
to A -> B -> C (origin/master) ->D (wip)
\-> E (cpcloud:read-html-lxml-skips)
cpcloud
added a commit
that referenced
this pull request
Oct 8, 2013
TST/CI/BUG: fix borked call to read_html testing code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5150.