From db38b7b51fa22b2de76ebdd5d0d29fd9b56ac6ed Mon Sep 17 00:00:00 2001 From: Maria Stazherova Date: Tue, 10 Jan 2023 22:48:17 +0000 Subject: [PATCH 1/5] fillna parr test added --- pandas/tests/series/methods/test_fillna.py | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/pandas/tests/series/methods/test_fillna.py b/pandas/tests/series/methods/test_fillna.py index 47703b294c2b1..12360082004df 100644 --- a/pandas/tests/series/methods/test_fillna.py +++ b/pandas/tests/series/methods/test_fillna.py @@ -20,6 +20,8 @@ date_range, isna, ) +from pandas.core.arrays import period_array + import pandas._testing as tm @@ -946,3 +948,27 @@ def test_datetime64tz_fillna_round_issue(self): ) tm.assert_series_equal(filled, expected) + + def test_fillna_parr(self): + # GH-24537 + dti = date_range( + Timestamp.max - Timedelta(nanoseconds=10), periods=5, freq="ns" + ) + pi = dti.to_period("ns") + parr = pi._data + parr[2] = NaT + arr = period_array( + [ + Timestamp("2262-04-11 23:47:16.854775797"), + Timestamp("2262-04-11 23:47:16.854775798"), + Timestamp("2262-04-11 23:47:16.854775798"), + Timestamp("2262-04-11 23:47:16.854775800"), + Timestamp("2262-04-11 23:47:16.854775801"), + ], + freq="ns", + ) + expected = Series(arr) + + filled = Series(parr.fillna(method="pad")) + + tm.assert_series_equal(filled, expected) From c212622300795aa49623899bd03a35f303fd9b20 Mon Sep 17 00:00:00 2001 From: Maria Stazherova Date: Tue, 10 Jan 2023 23:11:04 +0000 Subject: [PATCH 2/5] isort --- pandas/tests/series/methods/test_fillna.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/series/methods/test_fillna.py b/pandas/tests/series/methods/test_fillna.py index 12360082004df..9fa0be7c31fc1 100644 --- a/pandas/tests/series/methods/test_fillna.py +++ b/pandas/tests/series/methods/test_fillna.py @@ -20,9 +20,9 @@ date_range, isna, ) -from pandas.core.arrays import period_array import pandas._testing as tm +from pandas.core.arrays import period_array class TestSeriesFillNA: From 9432dbfe4df4f24a047598c366c37d6656d399ed Mon Sep 17 00:00:00 2001 From: Maria Stazherova Date: Tue, 10 Jan 2023 23:16:17 +0000 Subject: [PATCH 3/5] remove wrong empty line --- pandas/tests/series/methods/test_fillna.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pandas/tests/series/methods/test_fillna.py b/pandas/tests/series/methods/test_fillna.py index 9fa0be7c31fc1..f99034f095bf6 100644 --- a/pandas/tests/series/methods/test_fillna.py +++ b/pandas/tests/series/methods/test_fillna.py @@ -20,7 +20,6 @@ date_range, isna, ) - import pandas._testing as tm from pandas.core.arrays import period_array From c54251974b8e1bc0dbf0923f613e8cc5c4886b4b Mon Sep 17 00:00:00 2001 From: Maria Stazherova Date: Wed, 11 Jan 2023 21:45:23 +0000 Subject: [PATCH 4/5] small adjustments --- pandas/tests/series/methods/test_fillna.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pandas/tests/series/methods/test_fillna.py b/pandas/tests/series/methods/test_fillna.py index f99034f095bf6..f4f88c8573bcd 100644 --- a/pandas/tests/series/methods/test_fillna.py +++ b/pandas/tests/series/methods/test_fillna.py @@ -953,9 +953,8 @@ def test_fillna_parr(self): dti = date_range( Timestamp.max - Timedelta(nanoseconds=10), periods=5, freq="ns" ) - pi = dti.to_period("ns") - parr = pi._data - parr[2] = NaT + ser = Series(dti.to_period("ns")) + ser[2] = NaT arr = period_array( [ Timestamp("2262-04-11 23:47:16.854775797"), @@ -968,6 +967,6 @@ def test_fillna_parr(self): ) expected = Series(arr) - filled = Series(parr.fillna(method="pad")) + filled = Series(ser.fillna(method="pad")) tm.assert_series_equal(filled, expected) From 5f494f050ea28fb88ec69f4520687739720c5c9d Mon Sep 17 00:00:00 2001 From: Maria Stazherova Date: Thu, 12 Jan 2023 09:03:21 +0000 Subject: [PATCH 5/5] remove redundant cast --- pandas/tests/series/methods/test_fillna.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/series/methods/test_fillna.py b/pandas/tests/series/methods/test_fillna.py index f4f88c8573bcd..9fded26c37caf 100644 --- a/pandas/tests/series/methods/test_fillna.py +++ b/pandas/tests/series/methods/test_fillna.py @@ -967,6 +967,6 @@ def test_fillna_parr(self): ) expected = Series(arr) - filled = Series(ser.fillna(method="pad")) + filled = ser.fillna(method="pad") tm.assert_series_equal(filled, expected)