From 0d48c9cb419182329d73ffa3e29e33e0dfaa77a2 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Wed, 21 Dec 2022 13:19:21 -0800 Subject: [PATCH 01/14] disable some workflows --- .github/workflows/32-bit-linux.yml | 1 + .github/workflows/code-checks.yml | 5 +++++ .github/workflows/docbuild-and-upload.yml | 1 + .github/workflows/macos-windows.yml | 1 + .github/workflows/python-dev.yml | 1 + 5 files changed, 9 insertions(+) diff --git a/.github/workflows/32-bit-linux.yml b/.github/workflows/32-bit-linux.yml index 438d2c7b4174e..71424de8ded10 100644 --- a/.github/workflows/32-bit-linux.yml +++ b/.github/workflows/32-bit-linux.yml @@ -17,6 +17,7 @@ permissions: jobs: pytest: + if: false runs-on: ubuntu-22.04 steps: - name: Checkout diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 280b6ed601f08..754693351c58a 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -19,6 +19,7 @@ permissions: jobs: pre_commit: + if: false name: pre-commit runs-on: ubuntu-22.04 concurrency: @@ -40,6 +41,7 @@ jobs: extra_args: --verbose --all-files docstring_typing_manual_hooks: + if: false name: Docstring validation, typing, and other manual pre-commit hooks runs-on: ubuntu-22.04 defaults: @@ -103,6 +105,7 @@ jobs: if: ${{ steps.build.outcome == 'success' && always() }} asv-benchmarks: + if: false name: ASV Benchmarks runs-on: ubuntu-22.04 defaults: @@ -134,6 +137,7 @@ jobs: asv run --quick --dry-run --strict --durations=30 --python=same build_docker_dev_environment: + if: false name: Build Docker Dev Environment runs-on: ubuntu-22.04 defaults: @@ -161,6 +165,7 @@ jobs: run: docker run --rm pandas-dev-env python -c "import pandas as pd; print(pd.show_versions())" requirements-dev-text-installable: + if: false name: Test install requirements-dev.txt runs-on: ubuntu-22.04 diff --git a/.github/workflows/docbuild-and-upload.yml b/.github/workflows/docbuild-and-upload.yml index ee79c10c12d4e..945ada1f7a20b 100644 --- a/.github/workflows/docbuild-and-upload.yml +++ b/.github/workflows/docbuild-and-upload.yml @@ -21,6 +21,7 @@ permissions: jobs: web_and_docs: + if: false name: Doc Build and Upload runs-on: ubuntu-22.04 diff --git a/.github/workflows/macos-windows.yml b/.github/workflows/macos-windows.yml index ca6fd63d749ee..32ee9bca85101 100644 --- a/.github/workflows/macos-windows.yml +++ b/.github/workflows/macos-windows.yml @@ -24,6 +24,7 @@ permissions: jobs: pytest: + if: false defaults: run: shell: bash -el {0} diff --git a/.github/workflows/python-dev.yml b/.github/workflows/python-dev.yml index 220c1e464742e..bb489abdc47f8 100644 --- a/.github/workflows/python-dev.yml +++ b/.github/workflows/python-dev.yml @@ -44,6 +44,7 @@ permissions: jobs: build: + if: false # if: false # Uncomment this to freeze the workflow, comment it to unfreeze runs-on: ${{ matrix.os }} strategy: From cf9fc6a825609970d881352a4275a2e9265aa505 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Wed, 21 Dec 2022 13:31:00 -0800 Subject: [PATCH 02/14] test internal warning raises --- ci/run_tests.sh | 2 +- pandas/core/common.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ci/run_tests.sh b/ci/run_tests.sh index e6de5caf955fc..911b3141b6351 100755 --- a/ci/run_tests.sh +++ b/ci/run_tests.sh @@ -24,7 +24,7 @@ if [[ $(uname) == "Linux" && -z $DISPLAY ]]; then XVFB="xvfb-run " fi -PYTEST_CMD="${XVFB}pytest -r fEs -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE $PYTEST_TARGET" +PYTEST_CMD="${XVFB}pytest -r fEs -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE pandas/tests/test_common.py" if [[ "$PATTERN" ]]; then PYTEST_CMD="$PYTEST_CMD -m \"$PATTERN\"" diff --git a/pandas/core/common.py b/pandas/core/common.py index 8764ee0ea6ed7..8497d7a2e9ca9 100644 --- a/pandas/core/common.py +++ b/pandas/core/common.py @@ -380,6 +380,9 @@ def standardize_mapping(into): DataFrame.to_dict Series.to_dict """ + import warnings + + warnings.warn("Should raise", UserWarning) if not inspect.isclass(into): if isinstance(into, defaultdict): return partial(defaultdict, into.default_factory) From 93cb82ac4fbc4aaa16a3280899d94a85c2e9ed89 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Wed, 21 Dec 2022 13:52:22 -0800 Subject: [PATCH 03/14] Add $ --- .github/workflows/ubuntu.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 007de6385dd69..073efaee7c723 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -96,7 +96,7 @@ jobs: LC_ALL: ${{ matrix.lc_all || '' }} PANDAS_DATA_MANAGER: ${{ matrix.pandas_data_manager || 'block' }} PANDAS_COPY_ON_WRITE: ${{ matrix.pandas_copy_on_write || '0' }} - TEST_ARGS: ${{ matrix.test_args || '-W error:::pandas' }} + TEST_ARGS: ${{ matrix.test_args || '-W error:::$pandas' }} PYTEST_WORKERS: ${{ contains(matrix.pattern, 'not single_cpu') && 'auto' || '1' }} PYTEST_TARGET: ${{ matrix.pytest_target || 'pandas' }} IS_PYPY: ${{ contains(matrix.env_file, 'pypy') }} From 3b83f9e4b3841eba9ff29c77ee82d1825cea6376 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Wed, 21 Dec 2022 15:10:14 -0800 Subject: [PATCH 04/14] Revert "disable some workflows" This reverts commit 0d48c9cb419182329d73ffa3e29e33e0dfaa77a2. --- .github/workflows/32-bit-linux.yml | 1 - .github/workflows/code-checks.yml | 5 ----- .github/workflows/docbuild-and-upload.yml | 1 - .github/workflows/macos-windows.yml | 1 - .github/workflows/python-dev.yml | 1 - 5 files changed, 9 deletions(-) diff --git a/.github/workflows/32-bit-linux.yml b/.github/workflows/32-bit-linux.yml index 71424de8ded10..438d2c7b4174e 100644 --- a/.github/workflows/32-bit-linux.yml +++ b/.github/workflows/32-bit-linux.yml @@ -17,7 +17,6 @@ permissions: jobs: pytest: - if: false runs-on: ubuntu-22.04 steps: - name: Checkout diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 754693351c58a..280b6ed601f08 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -19,7 +19,6 @@ permissions: jobs: pre_commit: - if: false name: pre-commit runs-on: ubuntu-22.04 concurrency: @@ -41,7 +40,6 @@ jobs: extra_args: --verbose --all-files docstring_typing_manual_hooks: - if: false name: Docstring validation, typing, and other manual pre-commit hooks runs-on: ubuntu-22.04 defaults: @@ -105,7 +103,6 @@ jobs: if: ${{ steps.build.outcome == 'success' && always() }} asv-benchmarks: - if: false name: ASV Benchmarks runs-on: ubuntu-22.04 defaults: @@ -137,7 +134,6 @@ jobs: asv run --quick --dry-run --strict --durations=30 --python=same build_docker_dev_environment: - if: false name: Build Docker Dev Environment runs-on: ubuntu-22.04 defaults: @@ -165,7 +161,6 @@ jobs: run: docker run --rm pandas-dev-env python -c "import pandas as pd; print(pd.show_versions())" requirements-dev-text-installable: - if: false name: Test install requirements-dev.txt runs-on: ubuntu-22.04 diff --git a/.github/workflows/docbuild-and-upload.yml b/.github/workflows/docbuild-and-upload.yml index 945ada1f7a20b..ee79c10c12d4e 100644 --- a/.github/workflows/docbuild-and-upload.yml +++ b/.github/workflows/docbuild-and-upload.yml @@ -21,7 +21,6 @@ permissions: jobs: web_and_docs: - if: false name: Doc Build and Upload runs-on: ubuntu-22.04 diff --git a/.github/workflows/macos-windows.yml b/.github/workflows/macos-windows.yml index 32ee9bca85101..ca6fd63d749ee 100644 --- a/.github/workflows/macos-windows.yml +++ b/.github/workflows/macos-windows.yml @@ -24,7 +24,6 @@ permissions: jobs: pytest: - if: false defaults: run: shell: bash -el {0} diff --git a/.github/workflows/python-dev.yml b/.github/workflows/python-dev.yml index bb489abdc47f8..220c1e464742e 100644 --- a/.github/workflows/python-dev.yml +++ b/.github/workflows/python-dev.yml @@ -44,7 +44,6 @@ permissions: jobs: build: - if: false # if: false # Uncomment this to freeze the workflow, comment it to unfreeze runs-on: ${{ matrix.os }} strategy: From 76591165a7cf5341c541a8cd149f061161954e55 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Wed, 21 Dec 2022 15:10:21 -0800 Subject: [PATCH 05/14] Revert "test internal warning raises" This reverts commit cf9fc6a825609970d881352a4275a2e9265aa505. --- ci/run_tests.sh | 2 +- pandas/core/common.py | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/ci/run_tests.sh b/ci/run_tests.sh index 911b3141b6351..e6de5caf955fc 100755 --- a/ci/run_tests.sh +++ b/ci/run_tests.sh @@ -24,7 +24,7 @@ if [[ $(uname) == "Linux" && -z $DISPLAY ]]; then XVFB="xvfb-run " fi -PYTEST_CMD="${XVFB}pytest -r fEs -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE pandas/tests/test_common.py" +PYTEST_CMD="${XVFB}pytest -r fEs -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE $PYTEST_TARGET" if [[ "$PATTERN" ]]; then PYTEST_CMD="$PYTEST_CMD -m \"$PATTERN\"" diff --git a/pandas/core/common.py b/pandas/core/common.py index 8497d7a2e9ca9..8764ee0ea6ed7 100644 --- a/pandas/core/common.py +++ b/pandas/core/common.py @@ -380,9 +380,6 @@ def standardize_mapping(into): DataFrame.to_dict Series.to_dict """ - import warnings - - warnings.warn("Should raise", UserWarning) if not inspect.isclass(into): if isinstance(into, defaultdict): return partial(defaultdict, into.default_factory) From 7c439dd814c33b74ecfc7a5694efd14becb48244 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Wed, 21 Dec 2022 15:11:13 -0800 Subject: [PATCH 06/14] Add $ --- .github/workflows/macos-windows.yml | 2 +- .github/workflows/ubuntu.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/macos-windows.yml b/.github/workflows/macos-windows.yml index ca6fd63d749ee..bf91118e300f7 100644 --- a/.github/workflows/macos-windows.yml +++ b/.github/workflows/macos-windows.yml @@ -16,7 +16,7 @@ env: PANDAS_CI: 1 PYTEST_TARGET: pandas PATTERN: "not slow and not db and not network and not single_cpu" - TEST_ARGS: "-W error:::pandas" + TEST_ARGS: "-W error:::$pandas" permissions: diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 073efaee7c723..d79cebcfc96d8 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -98,7 +98,7 @@ jobs: PANDAS_COPY_ON_WRITE: ${{ matrix.pandas_copy_on_write || '0' }} TEST_ARGS: ${{ matrix.test_args || '-W error:::$pandas' }} PYTEST_WORKERS: ${{ contains(matrix.pattern, 'not single_cpu') && 'auto' || '1' }} - PYTEST_TARGET: ${{ matrix.pytest_target || 'pandas' }} + PYTEST_TARGET: ${{ matrix.pytest_target || '$pandas' }} IS_PYPY: ${{ contains(matrix.env_file, 'pypy') }} # TODO: re-enable coverage on pypy, its slow COVERAGE: ${{ !contains(matrix.env_file, 'pypy') }} From 0d0460bb920cba96531ff2ebac2c1da8930e5ed7 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Thu, 22 Dec 2022 18:59:51 -0800 Subject: [PATCH 07/14] try alternative method --- .github/workflows/macos-windows.yml | 2 +- .github/workflows/ubuntu.yml | 9 ++++++--- ci/run_tests.sh | 7 +++++++ 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/.github/workflows/macos-windows.yml b/.github/workflows/macos-windows.yml index bf91118e300f7..97453fcda5a16 100644 --- a/.github/workflows/macos-windows.yml +++ b/.github/workflows/macos-windows.yml @@ -16,7 +16,7 @@ env: PANDAS_CI: 1 PYTEST_TARGET: pandas PATTERN: "not slow and not db and not network and not single_cpu" - TEST_ARGS: "-W error:::$pandas" + ERROR_ON_WARNINGS: true permissions: diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index d79cebcfc96d8..72d54e73bf65d 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -38,7 +38,7 @@ jobs: - name: "Minimum Versions" env_file: actions-38-minimum_versions.yaml pattern: "not slow and not network and not single_cpu" - test_args: "" + error_on_warnings: false - name: "Locale: it_IT" env_file: actions-38.yaml pattern: "not slow and not network and not single_cpu" @@ -63,20 +63,22 @@ jobs: env_file: actions-310.yaml pattern: "not slow and not network and not single_cpu" pandas_copy_on_write: "1" - test_args: "" + error_on_warnings: false - name: "Data Manager" env_file: actions-38.yaml pattern: "not slow and not network and not single_cpu" pandas_data_manager: "array" - test_args: "" + error_on_warnings: false - name: "Pypy" env_file: actions-pypy-38.yaml pattern: "not slow and not network and not single_cpu" test_args: "--max-worker-restart 0" + error_on_warnings: false - name: "Numpy Dev" env_file: actions-310-numpydev.yaml pattern: "not slow and not network and not single_cpu" test_args: "-W error::DeprecationWarning:numpy -W error::FutureWarning:numpy" + error_on_warnings: false exclude: - env_file: actions-39.yaml pyarrow_version: "6" @@ -92,6 +94,7 @@ jobs: ENV_FILE: ci/deps/${{ matrix.env_file }} PATTERN: ${{ matrix.pattern }} EXTRA_APT: ${{ matrix.extra_apt || '' }} + ERROR_ON_WARNINGS: ${{ matrix.error_on_warnings || true }} LANG: ${{ matrix.lang || '' }} LC_ALL: ${{ matrix.lc_all || '' }} PANDAS_DATA_MANAGER: ${{ matrix.pandas_data_manager || 'block' }} diff --git a/ci/run_tests.sh b/ci/run_tests.sh index e6de5caf955fc..6ac1762bd253a 100755 --- a/ci/run_tests.sh +++ b/ci/run_tests.sh @@ -30,6 +30,13 @@ if [[ "$PATTERN" ]]; then PYTEST_CMD="$PYTEST_CMD -m \"$PATTERN\"" fi +if [[ "$ERROR_ON_WARNINGS" == "true" ]]; then + for pth in $(find pandas -name '*.py' -not -path "pandas/tests/*"); + do + PYTEST_CMD="$PYTEST_CMD -W error:::$pth" + done +fi + echo $PYTEST_CMD sh -c "$PYTEST_CMD" From d224261a117af0c6892ea358c6699f3870b956a6 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Fri, 23 Dec 2022 15:36:24 -0800 Subject: [PATCH 08/14] Fix typos --- .github/workflows/ubuntu.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 72d54e73bf65d..84bcacd2cbad8 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -99,9 +99,9 @@ jobs: LC_ALL: ${{ matrix.lc_all || '' }} PANDAS_DATA_MANAGER: ${{ matrix.pandas_data_manager || 'block' }} PANDAS_COPY_ON_WRITE: ${{ matrix.pandas_copy_on_write || '0' }} - TEST_ARGS: ${{ matrix.test_args || '-W error:::$pandas' }} + TEST_ARGS: ${{ matrix.test_args || '' }} PYTEST_WORKERS: ${{ contains(matrix.pattern, 'not single_cpu') && 'auto' || '1' }} - PYTEST_TARGET: ${{ matrix.pytest_target || '$pandas' }} + PYTEST_TARGET: ${{ matrix.pytest_target || 'pandas' }} IS_PYPY: ${{ contains(matrix.env_file, 'pypy') }} # TODO: re-enable coverage on pypy, its slow COVERAGE: ${{ !contains(matrix.env_file, 'pypy') }} From e38a9c6a115fdff41979f299e8b3aabac7976e96 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Tue, 27 Dec 2022 10:23:27 -0800 Subject: [PATCH 09/14] test new check --- pandas/core/common.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pandas/core/common.py b/pandas/core/common.py index 8764ee0ea6ed7..91214d3a92204 100644 --- a/pandas/core/common.py +++ b/pandas/core/common.py @@ -380,6 +380,9 @@ def standardize_mapping(into): DataFrame.to_dict Series.to_dict """ + import warnings + + warnings.warn("TEST: Should raise", UserWarning) if not inspect.isclass(into): if isinstance(into, defaultdict): return partial(defaultdict, into.default_factory) From fe1f3fb06e13cb8daebdc968b9f37405503e12cd Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Tue, 27 Dec 2022 13:13:28 -0800 Subject: [PATCH 10/14] Modules not paths --- ci/run_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/run_tests.sh b/ci/run_tests.sh index 6ac1762bd253a..769e0f29ae32c 100755 --- a/ci/run_tests.sh +++ b/ci/run_tests.sh @@ -31,7 +31,7 @@ if [[ "$PATTERN" ]]; then fi if [[ "$ERROR_ON_WARNINGS" == "true" ]]; then - for pth in $(find pandas -name '*.py' -not -path "pandas/tests/*"); + for pth in $(find pandas -name '*.py' -not -path "pandas/tests/*" | sed -e 's/\.py//g' -e 's/\/__init__//g' -e 's/\//./g'); do PYTEST_CMD="$PYTEST_CMD -W error:::$pth" done From d50fe73e6d4193a5d656fd6b97f564efc36c2de1 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Tue, 27 Dec 2022 16:58:02 -0800 Subject: [PATCH 11/14] It works --- pandas/core/common.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/pandas/core/common.py b/pandas/core/common.py index 91214d3a92204..8764ee0ea6ed7 100644 --- a/pandas/core/common.py +++ b/pandas/core/common.py @@ -380,9 +380,6 @@ def standardize_mapping(into): DataFrame.to_dict Series.to_dict """ - import warnings - - warnings.warn("TEST: Should raise", UserWarning) if not inspect.isclass(into): if isinstance(into, defaultdict): return partial(defaultdict, into.default_factory) From 0127a637fa58316b8c8d93a0eab27f2ec22e597d Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Wed, 28 Dec 2022 10:29:27 -0800 Subject: [PATCH 12/14] Catch new warnings --- pandas/tests/arithmetic/test_timedelta64.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/pandas/tests/arithmetic/test_timedelta64.py b/pandas/tests/arithmetic/test_timedelta64.py index c9bfb5e29460e..72b32246bf8b5 100644 --- a/pandas/tests/arithmetic/test_timedelta64.py +++ b/pandas/tests/arithmetic/test_timedelta64.py @@ -1756,12 +1756,18 @@ def test_td64arr_floordiv_td64arr_with_nat( # columns without missing values expected[[0, 1]] = expected[[0, 1]].astype("int64") - result = left // right + with tm.maybe_produces_warning( + RuntimeWarning, box is pd.array, check_stacklevel=False + ): + result = left // right tm.assert_equal(result, expected) # case that goes through __rfloordiv__ with arraylike - result = np.asarray(left) // right + with tm.maybe_produces_warning( + RuntimeWarning, box is pd.array, check_stacklevel=False + ): + result = np.asarray(left) // right tm.assert_equal(result, expected) @pytest.mark.filterwarnings("ignore:invalid value encountered:RuntimeWarning") From d57d7c21363f3edaa66465443e449520fea8860f Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Wed, 28 Dec 2022 14:07:47 -0800 Subject: [PATCH 13/14] Use 0/1 --- .github/workflows/macos-windows.yml | 2 +- .github/workflows/ubuntu.yml | 12 ++++++------ ci/run_tests.sh | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/macos-windows.yml b/.github/workflows/macos-windows.yml index f2c33e97fe365..d762e20db196a 100644 --- a/.github/workflows/macos-windows.yml +++ b/.github/workflows/macos-windows.yml @@ -16,7 +16,7 @@ env: PANDAS_CI: 1 PYTEST_TARGET: pandas PATTERN: "not slow and not db and not network and not single_cpu" - ERROR_ON_WARNINGS: true + ERROR_ON_WARNINGS: "1" permissions: diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 4438e4d6c4fb5..245ccba05ff1e 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -38,7 +38,7 @@ jobs: - name: "Minimum Versions" env_file: actions-38-minimum_versions.yaml pattern: "not slow and not network and not single_cpu" - error_on_warnings: false + error_on_warnings: "0" - name: "Locale: it_IT" env_file: actions-38.yaml pattern: "not slow and not network and not single_cpu" @@ -63,22 +63,22 @@ jobs: env_file: actions-310.yaml pattern: "not slow and not network and not single_cpu" pandas_copy_on_write: "1" - error_on_warnings: false + error_on_warnings: "0" - name: "Data Manager" env_file: actions-38.yaml pattern: "not slow and not network and not single_cpu" pandas_data_manager: "array" - error_on_warnings: false + error_on_warnings: "0" - name: "Pypy" env_file: actions-pypy-38.yaml pattern: "not slow and not network and not single_cpu" test_args: "--max-worker-restart 0" - error_on_warnings: false + error_on_warnings: "0" - name: "Numpy Dev" env_file: actions-310-numpydev.yaml pattern: "not slow and not network and not single_cpu" test_args: "-W error::DeprecationWarning:numpy -W error::FutureWarning:numpy" - error_on_warnings: false + error_on_warnings: "0" exclude: - env_file: actions-38.yaml pyarrow_version: "7" @@ -98,7 +98,7 @@ jobs: ENV_FILE: ci/deps/${{ matrix.env_file }} PATTERN: ${{ matrix.pattern }} EXTRA_APT: ${{ matrix.extra_apt || '' }} - ERROR_ON_WARNINGS: ${{ matrix.error_on_warnings || true }} + ERROR_ON_WARNINGS: ${{ matrix.error_on_warnings || "1" }} LANG: ${{ matrix.lang || '' }} LC_ALL: ${{ matrix.lc_all || '' }} PANDAS_DATA_MANAGER: ${{ matrix.pandas_data_manager || 'block' }} diff --git a/ci/run_tests.sh b/ci/run_tests.sh index 769e0f29ae32c..a48d6c1ad6580 100755 --- a/ci/run_tests.sh +++ b/ci/run_tests.sh @@ -30,7 +30,7 @@ if [[ "$PATTERN" ]]; then PYTEST_CMD="$PYTEST_CMD -m \"$PATTERN\"" fi -if [[ "$ERROR_ON_WARNINGS" == "true" ]]; then +if [[ "$ERROR_ON_WARNINGS" == "1" ]]; then for pth in $(find pandas -name '*.py' -not -path "pandas/tests/*" | sed -e 's/\.py//g' -e 's/\/__init__//g' -e 's/\//./g'); do PYTEST_CMD="$PYTEST_CMD -W error:::$pth" From 51e9688754c2c64ed1364dc3a25986f91635e803 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Date: Wed, 28 Dec 2022 16:34:46 -0800 Subject: [PATCH 14/14] Fix workflow --- .github/workflows/ubuntu.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index 245ccba05ff1e..9c93725ea15ec 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -98,7 +98,7 @@ jobs: ENV_FILE: ci/deps/${{ matrix.env_file }} PATTERN: ${{ matrix.pattern }} EXTRA_APT: ${{ matrix.extra_apt || '' }} - ERROR_ON_WARNINGS: ${{ matrix.error_on_warnings || "1" }} + ERROR_ON_WARNINGS: ${{ matrix.error_on_warnings || '1' }} LANG: ${{ matrix.lang || '' }} LC_ALL: ${{ matrix.lc_all || '' }} PANDAS_DATA_MANAGER: ${{ matrix.pandas_data_manager || 'block' }}