From 2001c778abf9f46ec754e1ef854f9ef7b398654e Mon Sep 17 00:00:00 2001 From: Thierry Moisan Date: Tue, 8 Nov 2022 20:49:31 -0500 Subject: [PATCH] STYLE: fix pylint useless-else-on-loop warnings --- pandas/core/internals/array_manager.py | 3 +-- pyproject.toml | 1 - scripts/sync_flake8_versions.py | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/pandas/core/internals/array_manager.py b/pandas/core/internals/array_manager.py index f6e50d658a580..d325e5e9b92cc 100644 --- a/pandas/core/internals/array_manager.py +++ b/pandas/core/internals/array_manager.py @@ -697,8 +697,7 @@ def _equal_values(self, other) -> bool: for left, right in zip(self.arrays, other.arrays): if not array_equals(left, right): return False - else: - return True + return True # TODO # to_dict diff --git a/pyproject.toml b/pyproject.toml index 18150f8d5220e..2ff09fc9766c5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -170,7 +170,6 @@ disable = [ "unused-import", "unused-variable", "using-constant-test", - "useless-else-on-loop", "useless-parent-delegation" ] diff --git a/scripts/sync_flake8_versions.py b/scripts/sync_flake8_versions.py index d19501051349f..8852634c5d796 100644 --- a/scripts/sync_flake8_versions.py +++ b/scripts/sync_flake8_versions.py @@ -55,8 +55,7 @@ def _get_repo_hook(repos: Sequence[Repo], hook_name: str) -> tuple[Repo, YamlMap for hook in repo["hooks"]: if hook["id"] == hook_name: return repo, hook - else: # pragma: no cover - raise RuntimeError(f"Repo with hook {hook_name} not found") + raise RuntimeError(f"Repo with hook {hook_name} not found") # pragma: no cover def _conda_to_pip_compat(dep):