Skip to content

ENH: Add index param to df.to_dict #48429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 13, 2022
Merged

ENH: Add index param to df.to_dict #48429

merged 8 commits into from
Sep 13, 2022

Conversation

yuanx749
Copy link
Contributor

@yuanx749 yuanx749 commented Sep 7, 2022 •
edited
Loading

@mroeschke mroeschke added the DataFrame DataFrame data structure label Sep 8, 2022
datapythonista
datapythonista reviewed Sep 10, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuanx749, nice PR. General idea looks good, I just added couple of comments.

datapythonista
datapythonista approved these changes Sep 10, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @yuanx749, really nice, lgtm

mroeschke
mroeschke reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Could you resolve the merge conflict?

@yuanx749
Copy link
Contributor Author

Looks pretty good. Could you resolve the merge conflict?

Resolved.

@mroeschke mroeschke added this to the 1.6 milestone Sep 13, 2022
@mroeschke mroeschke merged commit 68d6b47 into pandas-dev:main Sep 13, 2022
@mroeschke
Copy link
Member

Thanks @yuanx749

@yuanx749 yuanx749 deleted the enh-to-dict-index branch September 14, 2022 03:33
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@yuanx749 @noatamir
ENH: Add index param to df.to_dict (pandas-dev#48429)
67263b1 
* EHN: Add index param to df.to_dict

* Add whatsnew

* Move whatsnew

* Refactor duplicate code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
DataFrame DataFrame data structure
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Add index param to to_dict like in to_json.
3 participants
@yuanx749 @mroeschke @datapythonista