From 002a4ad869f73825400bd4e87bbf839718cf1fcd Mon Sep 17 00:00:00 2001 From: Jeffrey Tratner Date: Sat, 31 Aug 2013 18:31:31 -0400 Subject: [PATCH] DOC: Updates to CONTRIBUTING.md --- CONTRIBUTING.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 32b0c27fc8691..ac972b47e7b60 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,8 +32,8 @@ your contribution or address the issue you're having. - **Make sure the test suite passes**., and that means on python3 as well. You can use "test_fast.sh", or tox locally and/or enable Travis-CI on your fork. See the "Getting Travis-CI going" below. - - We suggest you enable Travis-CI on your fork, to make it easier for the team - to see that the PR does indeed pass all the tests. + - If you are changing any code, you need to enable Travis-CI on your fork, + to make it easier for the team to see that the PR does indeed pass all the tests. - Back-compatibility **really** matters. Pandas already has a large user-base and a lot of existing user code. Don't break old code if you can avoid it Explain the need if there is one in the PR. @@ -69,7 +69,8 @@ your contribution or address the issue you're having. with self.assertRaises(ValueError): foo - which fails on python 2.6, use `self.assertRaises(TheException,func,args)` instead. + which fails on python 2.6. You need to use `assertRaises` from + `pandas.util.testing` instead (or use `self.assertRaises(TheException,func,args)`). - doc/source/release.rst and doc/source/vx.y.z.txt contain an on-going changelog for each release as it is worked on. Add entries to these files