From 6b03d6e32fc7d7c0c3291ccd56788648253ed27e Mon Sep 17 00:00:00 2001 From: Matthew Roeschke Date: Sat, 12 Mar 2022 14:54:56 -0800 Subject: [PATCH 1/2] TST: xfail(strict=False) flaky hashtable test on ARM --- pandas/tests/libs/test_hashtable.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/pandas/tests/libs/test_hashtable.py b/pandas/tests/libs/test_hashtable.py index 6af81468ef1ef..414eae2f79e4d 100644 --- a/pandas/tests/libs/test_hashtable.py +++ b/pandas/tests/libs/test_hashtable.py @@ -6,6 +6,7 @@ import pytest from pandas._libs import hashtable as ht +from pandas.compat import is_platform_arm import pandas as pd import pandas._testing as tm @@ -246,7 +247,17 @@ def test_lookup_overflow(self, writable): (ht.Float64HashTable, ht.Float64Vector, "float64", False), (ht.Int64HashTable, ht.Int64Vector, "int64", False), (ht.Int32HashTable, ht.Int32Vector, "int32", False), - (ht.UInt64HashTable, ht.UInt64Vector, "uint64", False), + pytest.param( + ht.UInt64HashTable, + ht.UInt64Vector, + "uint64", + False, + marks=pytest.mark.xfail( + is_platform_arm(), + reason="Sometimes doesn't raise on ARM.", + strict=False, + ), + ), ], ) def test_vector_resize( From 0c4fb4eb5daaea72d25e9c870e6b1f1aabdf3dca Mon Sep 17 00:00:00 2001 From: Matthew Roeschke Date: Mon, 14 Mar 2022 17:37:44 -0700 Subject: [PATCH 2/2] Seen on macOS too, assume it can just happen --- pandas/tests/libs/test_hashtable.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pandas/tests/libs/test_hashtable.py b/pandas/tests/libs/test_hashtable.py index 414eae2f79e4d..bed427da5dd12 100644 --- a/pandas/tests/libs/test_hashtable.py +++ b/pandas/tests/libs/test_hashtable.py @@ -6,7 +6,6 @@ import pytest from pandas._libs import hashtable as ht -from pandas.compat import is_platform_arm import pandas as pd import pandas._testing as tm @@ -253,8 +252,7 @@ def test_lookup_overflow(self, writable): "uint64", False, marks=pytest.mark.xfail( - is_platform_arm(), - reason="Sometimes doesn't raise on ARM.", + reason="Sometimes doesn't raise.", strict=False, ), ),