From 000016b6b9c54220c932a6e95db3f489e214ebe5 Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 12 Feb 2022 05:31:24 +0800 Subject: [PATCH 1/7] add test --- pandas/tests/series/methods/test_values.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pandas/tests/series/methods/test_values.py b/pandas/tests/series/methods/test_values.py index 479c7033a3fb5..671f600fc854c 100644 --- a/pandas/tests/series/methods/test_values.py +++ b/pandas/tests/series/methods/test_values.py @@ -2,6 +2,7 @@ import pytest from pandas import ( + Int64Dtype, IntervalIndex, Series, period_range, @@ -27,3 +28,12 @@ def test_values(self, datetime_series): tm.assert_almost_equal( datetime_series.values, datetime_series, check_dtype=False ) + + def test_values_multiplying_large_series_by_NA(self): + + Int64NA = Series([np.nan], dtype=Int64Dtype()).iloc[0] + + result = Int64NA * Series(np.zeros(10001)) + expected = Series(np.zeros(10001) * Int64NA) + + tm.assert_series_equal(result, expected) From 6dfd97fe84725662924fe45587e5d4dd19e4bf18 Mon Sep 17 00:00:00 2001 From: Khor Chean Wei Date: Sat, 12 Feb 2022 08:08:45 +0800 Subject: [PATCH 2/7] Update test_values.py --- pandas/tests/series/methods/test_values.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/series/methods/test_values.py b/pandas/tests/series/methods/test_values.py index 671f600fc854c..cd7b9db60d563 100644 --- a/pandas/tests/series/methods/test_values.py +++ b/pandas/tests/series/methods/test_values.py @@ -30,7 +30,7 @@ def test_values(self, datetime_series): ) def test_values_multiplying_large_series_by_NA(self): - + # GH#33701 Int64NA = Series([np.nan], dtype=Int64Dtype()).iloc[0] result = Int64NA * Series(np.zeros(10001)) From fd3f4bed639835bbbd299289925e6c5f4e2d1ca4 Mon Sep 17 00:00:00 2001 From: "chean.wei.khor" Date: Thu, 17 Feb 2022 22:22:05 +0800 Subject: [PATCH 3/7] update test case to another file --- pandas/tests/arrays/integer/test_arithmetic.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pandas/tests/arrays/integer/test_arithmetic.py b/pandas/tests/arrays/integer/test_arithmetic.py index d14a6d089ecd6..4c9d1ded3b5e5 100644 --- a/pandas/tests/arrays/integer/test_arithmetic.py +++ b/pandas/tests/arrays/integer/test_arithmetic.py @@ -314,3 +314,12 @@ def test_unary_int_operators(any_signed_int_ea_dtype, source, neg_target, abs_ta tm.assert_extension_array_equal(pos_result, arr) assert not tm.shares_memory(pos_result, arr) tm.assert_extension_array_equal(abs_result, abs_target) + + +def test_values_multiplying_large_series_by_NA(self): + # GH#33701 + + result = pd.NA * pd.Series(np.zeros(10001)) + expected = pd.Series(np.zeros(10001) * pd.NA) + + tm.assert_series_equal(result, expected) From dfa4240f56714dc81f1ae04b7b7a8307cd1fe80e Mon Sep 17 00:00:00 2001 From: Khor Chean Wei Date: Thu, 17 Feb 2022 22:29:37 +0800 Subject: [PATCH 4/7] Update test_values.py --- pandas/tests/series/methods/test_values.py | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/pandas/tests/series/methods/test_values.py b/pandas/tests/series/methods/test_values.py index cd7b9db60d563..f241d453a977b 100644 --- a/pandas/tests/series/methods/test_values.py +++ b/pandas/tests/series/methods/test_values.py @@ -2,7 +2,6 @@ import pytest from pandas import ( - Int64Dtype, IntervalIndex, Series, period_range, @@ -29,11 +28,4 @@ def test_values(self, datetime_series): datetime_series.values, datetime_series, check_dtype=False ) - def test_values_multiplying_large_series_by_NA(self): - # GH#33701 - Int64NA = Series([np.nan], dtype=Int64Dtype()).iloc[0] - - result = Int64NA * Series(np.zeros(10001)) - expected = Series(np.zeros(10001) * Int64NA) - - tm.assert_series_equal(result, expected) + From 7fb3e007fc6a28231ebb01c445336d1004ddc7d7 Mon Sep 17 00:00:00 2001 From: "chean.wei.khor" Date: Thu, 17 Feb 2022 22:30:24 +0800 Subject: [PATCH 5/7] update test case to another file --- pandas/tests/series/methods/test_values.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/pandas/tests/series/methods/test_values.py b/pandas/tests/series/methods/test_values.py index f241d453a977b..479c7033a3fb5 100644 --- a/pandas/tests/series/methods/test_values.py +++ b/pandas/tests/series/methods/test_values.py @@ -27,5 +27,3 @@ def test_values(self, datetime_series): tm.assert_almost_equal( datetime_series.values, datetime_series, check_dtype=False ) - - From 8e6d5397138af70e744c9d3b194fb5ac04f65b83 Mon Sep 17 00:00:00 2001 From: Khor Chean Wei Date: Thu, 17 Feb 2022 23:47:44 +0800 Subject: [PATCH 6/7] Update test_arithmetic.py --- pandas/tests/arrays/integer/test_arithmetic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/arrays/integer/test_arithmetic.py b/pandas/tests/arrays/integer/test_arithmetic.py index 4c9d1ded3b5e5..f58753b2f6817 100644 --- a/pandas/tests/arrays/integer/test_arithmetic.py +++ b/pandas/tests/arrays/integer/test_arithmetic.py @@ -316,7 +316,7 @@ def test_unary_int_operators(any_signed_int_ea_dtype, source, neg_target, abs_ta tm.assert_extension_array_equal(abs_result, abs_target) -def test_values_multiplying_large_series_by_NA(self): +def test_values_multiplying_large_series_by_NA(): # GH#33701 result = pd.NA * pd.Series(np.zeros(10001)) From 2bf6f93001548f1c3cf55d532f77c5825da1537e Mon Sep 17 00:00:00 2001 From: "chean.wei.khor" Date: Sat, 19 Feb 2022 12:28:33 +0800 Subject: [PATCH 7/7] change construct --- pandas/tests/arrays/integer/test_arithmetic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/arrays/integer/test_arithmetic.py b/pandas/tests/arrays/integer/test_arithmetic.py index f58753b2f6817..dc5071e7585a9 100644 --- a/pandas/tests/arrays/integer/test_arithmetic.py +++ b/pandas/tests/arrays/integer/test_arithmetic.py @@ -320,6 +320,6 @@ def test_values_multiplying_large_series_by_NA(): # GH#33701 result = pd.NA * pd.Series(np.zeros(10001)) - expected = pd.Series(np.zeros(10001) * pd.NA) + expected = pd.Series([pd.NA] * 10001) tm.assert_series_equal(result, expected)