From f74365e4ce75dab54224b6bd111e0cf43e336425 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke Date: Thu, 13 Jan 2022 15:06:04 -0800 Subject: [PATCH 1/3] TST: xfail test_arrowparquet_options for windows --- pandas/tests/io/test_fsspec.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pandas/tests/io/test_fsspec.py b/pandas/tests/io/test_fsspec.py index e3e8358aa6340..3b5024c4ec7f9 100644 --- a/pandas/tests/io/test_fsspec.py +++ b/pandas/tests/io/test_fsspec.py @@ -161,6 +161,7 @@ def test_to_parquet_new_file(monkeypatch, cleared_fs): @td.skip_if_no("pyarrow") +@pytest.mark.xfail(td.is_platform_windows(), reason="GH 45344") def test_arrowparquet_options(fsspectest): """Regression test for writing to a not-yet-existent GCS Parquet file.""" df = DataFrame({"a": [0]}) From ce23c8c0a844f6e336fcaa7ffa254cf2068e6315 Mon Sep 17 00:00:00 2001 From: Matthew Roeschke Date: Thu, 13 Jan 2022 15:08:16 -0800 Subject: [PATCH 2/3] Add direct import --- pandas/tests/io/test_fsspec.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pandas/tests/io/test_fsspec.py b/pandas/tests/io/test_fsspec.py index 3b5024c4ec7f9..8dc2f8269cac8 100644 --- a/pandas/tests/io/test_fsspec.py +++ b/pandas/tests/io/test_fsspec.py @@ -3,6 +3,7 @@ import numpy as np import pytest +from pandas.compat import is_platform_windows from pandas.compat._optional import VERSIONS from pandas import ( @@ -161,7 +162,7 @@ def test_to_parquet_new_file(monkeypatch, cleared_fs): @td.skip_if_no("pyarrow") -@pytest.mark.xfail(td.is_platform_windows(), reason="GH 45344") +@pytest.mark.xfail(is_platform_windows(), reason="GH 45344") def test_arrowparquet_options(fsspectest): """Regression test for writing to a not-yet-existent GCS Parquet file.""" df = DataFrame({"a": [0]}) From dd98618b4c6887ad4ef5dcb934d77d26f36b819b Mon Sep 17 00:00:00 2001 From: Matthew Roeschke Date: Thu, 13 Jan 2022 17:33:06 -0800 Subject: [PATCH 3/3] Mark as 3.8 only --- pandas/tests/io/test_fsspec.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pandas/tests/io/test_fsspec.py b/pandas/tests/io/test_fsspec.py index 8dc2f8269cac8..0648c60eb5016 100644 --- a/pandas/tests/io/test_fsspec.py +++ b/pandas/tests/io/test_fsspec.py @@ -1,4 +1,5 @@ import io +import sys import numpy as np import pytest @@ -162,7 +163,9 @@ def test_to_parquet_new_file(monkeypatch, cleared_fs): @td.skip_if_no("pyarrow") -@pytest.mark.xfail(is_platform_windows(), reason="GH 45344") +@pytest.mark.xfail( + is_platform_windows() and sys.version_info[:2] == (3, 8), reason="GH 45344" +) def test_arrowparquet_options(fsspectest): """Regression test for writing to a not-yet-existent GCS Parquet file.""" df = DataFrame({"a": [0]})