Skip to content

ERR: clarify PerformanceWarning for fragmented frame #42942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

mzeitlin11
Copy link
Member

xref some confusion in #42477. If this is thought an improvement, could target 1.3.2 since more users now see this error than in 1.2.x

@mzeitlin11 mzeitlin11 added DataFrame DataFrame data structure Indexing Related to indexing on series/frames, not to indexes themselves Warnings Warnings that appear or should be added to pandas labels Aug 9, 2021
@jreback jreback added this to the 1.3.2 milestone Aug 9, 2021
@jreback
Copy link
Contributor

jreback commented Aug 9, 2021

lgtm ping on green

@@ -45,6 +45,7 @@ Bug fixes
Other
~~~~~
- :meth:`pandas.read_parquet` now supports reading nullable dtypes with ``fastparquet`` versions above 0.7.1.
- Clarified suggested fix for ``PerformanceWarning`` emitted with a highly fragmented :class:`DataFrame` (:issue:`42579`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the release note above this one is not yet on 1.3.x (not backported), so this may need a manual backport.

Alternatively, I think we don't normally add a release note when just a message is changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good, have just removed note then

@jreback jreback merged commit 77443dc into pandas-dev:master Aug 9, 2021
@jreback
Copy link
Contributor

jreback commented Aug 9, 2021

thanks @mzeitlin11

@jreback
Copy link
Contributor

jreback commented Aug 9, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 9, 2021

Something went wrong ... Please have a look at my logs.

@mzeitlin11 mzeitlin11 deleted the perf_warning_msg branch August 9, 2021 23:06
simonjayhawkins pushed a commit that referenced this pull request Aug 10, 2021
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataFrame DataFrame data structure Indexing Related to indexing on series/frames, not to indexes themselves Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants