Skip to content

BUG: df.drop not separating missing labels with commas #42938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2021
Merged

BUG: df.drop not separating missing labels with commas #42938

merged 2 commits into from
Aug 10, 2021

Conversation

zeitlinv
Copy link
Contributor

@zeitlinv zeitlinv commented Aug 8, 2021

@jreback jreback added Error Reporting Incorrect or improved errors from pandas Indexing Related to indexing on series/frames, not to indexes themselves labels Aug 8, 2021
@jreback jreback added this to the 1.4 milestone Aug 8, 2021
phofl
phofl approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ready to merge @jreback

@jreback jreback merged commit 83fabfb into pandas-dev:master Aug 10, 2021
@jreback
Copy link
Contributor

jreback commented Aug 10, 2021

thanks @zeitlinv

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@zeitlinv @feefladder
BUG: df.drop not separating missing labels with commas (pandas-dev#42938
b507b6a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.4
3 participants
@zeitlinv @jreback @phofl