Skip to content

TST: Solution to doctest error in _parse_latex_header_span #42700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2021
Merged

TST: Solution to doctest error in _parse_latex_header_span #42700

merged 2 commits into from
Jul 26, 2021

Conversation

aneesh98
Copy link
Contributor

@aneesh98 aneesh98 commented Jul 24, 2021

The following commit fixes the doctext in _parse_latex_header_span. Solves issue #42673

The following commit fixes the doctext in _parse_latex_header_span. Solves issue #42673
Copy link
Contributor

@attack68 attack68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you want, you can add the file here, so it's validated in the CI, and no more errors are introduced:

pandas/io/sql.py \

@aneesh98
Copy link
Contributor Author

Thanks! If you want, you can add the file here, so it's validated in the CI, and no more errors are introduced:

pandas/io/sql.py \

Done. Please check the latest commit.

@aneesh98 aneesh98 requested a review from datapythonista July 25, 2021 09:13
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jul 25, 2021
@jreback jreback added this to the 1.4 milestone Jul 25, 2021
@jreback jreback added the Docs label Jul 25, 2021
@aneesh98
Copy link
Contributor Author

aneesh98 commented Jul 25, 2021

Can someone please help me in understanding why one check is failing? It looked like there is some conda virtual environment issue. I don't know if this information is relevant, but I've followed this section (https://pandas.pydata.org/docs/development/contributing_environment.html#creating-a-python-environment-pip) to setup a local environment.

@datapythonista
Copy link
Member

Sorry @aneesh98, my fault. You fixed one of the examples in that file, but there are couple more that are still failing. You can remove the file you added to ci/code_checks.sh (or fix those two cases). If you fix the other cases in the file, let them know in #42674.

Thanks!

@aneesh98
Copy link
Contributor Author

aneesh98 commented Jul 26, 2021

Hi @datapythonista. For fixing those 2 cases I'll have to make 2 different pull requests right?. Also am I supposed to put some message on #42674 before fixing it, because I guess someone else has already taken up the issue.
Thanks.

@datapythonista
Copy link
Member

Hi @datapythonista. For fixing those 2 cases I'll have to make 2 different pull requests right?. Also am I supposed to put some message on #42674 before fixing it, because I guess someone else has already taken up the issue.
Thanks.

Large PRs are usually discouraged. Since it's a waste of time to have to review a very big PR every time there is a new update to it. But I think in this case the PR will still be quite small and focused, so all in the same is surely ok.

It happens very often that people assign issues to themselves, and then they don't have the time to work on them. Since those are small fixes, I think several days without activity tells that this is quite likely to be the case. But it's surely polite to write a comment in the issue, and ask if there has been any progress, and if it's ok that you continue the work on it.

@aneesh98
Copy link
Contributor Author

Hi @datapythonista. For fixing those 2 cases I'll have to make 2 different pull requests right?. Also am I supposed to put some message on #42674 before fixing it, because I guess someone else has already taken up the issue.
Thanks.

Large PRs are usually discouraged. Since it's a waste of time to have to review a very big PR every time there is a new update to it. But I think in this case the PR will still be quite small and focused, so all in the same is surely ok.

It happens very often that people assign issues to themselves, and then they don't have the time to work on them. Since those are small fixes, I think several days without activity tells that this is quite likely to be the case. But it's surely polite to write a comment in the issue, and ask if there has been any progress, and if it's ok that you continue the work on it.

Okay. Thanks.

@jreback jreback merged commit b8d750f into pandas-dev:master Jul 26, 2021
@jreback
Copy link
Contributor

jreback commented Jul 26, 2021

thanks @aneesh98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Fix doctest in _parse_latex_header_span
4 participants