-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Solution to doctest error in _parse_latex_header_span #42700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Solution to doctest error in _parse_latex_header_span #42700
Conversation
The following commit fixes the doctext in _parse_latex_header_span. Solves issue #42673
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! If you want, you can add the file here, so it's validated in the CI, and no more errors are introduced:
Line 123 in c1aea79
pandas/io/sql.py \ |
Done. Please check the latest commit. |
Can someone please help me in understanding why one check is failing? It looked like there is some conda virtual environment issue. I don't know if this information is relevant, but I've followed this section (https://pandas.pydata.org/docs/development/contributing_environment.html#creating-a-python-environment-pip) to setup a local environment. |
Hi @datapythonista. For fixing those 2 cases I'll have to make 2 different pull requests right?. Also am I supposed to put some message on #42674 before fixing it, because I guess someone else has already taken up the issue. |
Large PRs are usually discouraged. Since it's a waste of time to have to review a very big PR every time there is a new update to it. But I think in this case the PR will still be quite small and focused, so all in the same is surely ok. It happens very often that people assign issues to themselves, and then they don't have the time to work on them. Since those are small fixes, I think several days without activity tells that this is quite likely to be the case. But it's surely polite to write a comment in the issue, and ask if there has been any progress, and if it's ok that you continue the work on it. |
Okay. Thanks. |
thanks @aneesh98 |
The following commit fixes the doctext in _parse_latex_header_span. Solves issue #42673