From 331fcc16b4e925c7bd290a0f31f7bb56d82b049c Mon Sep 17 00:00:00 2001 From: Brock Date: Tue, 2 Mar 2021 15:48:41 -0800 Subject: [PATCH 1/2] xfail #40144 --- pandas/tests/extension/base/groupby.py | 3 +++ pandas/tests/extension/test_boolean.py | 3 +++ 2 files changed, 6 insertions(+) diff --git a/pandas/tests/extension/base/groupby.py b/pandas/tests/extension/base/groupby.py index 30b115b9dba6f..7a40a5360156a 100644 --- a/pandas/tests/extension/base/groupby.py +++ b/pandas/tests/extension/base/groupby.py @@ -1,5 +1,7 @@ import pytest +from pandas.compat.numpy import is_numpy_dev + import pandas as pd import pandas._testing as tm from pandas.tests.extension.base.base import BaseExtensionTests @@ -73,6 +75,7 @@ def test_groupby_extension_apply(self, data_for_grouping, groupby_apply_op): df.groupby("A").apply(groupby_apply_op) df.groupby("A").B.apply(groupby_apply_op) + @pytest.mark.xfail(is_numpy_dev, reason="2021-03-02 #40144 expecting fix in numpy") def test_groupby_apply_identity(self, data_for_grouping): df = pd.DataFrame({"A": [1, 1, 2, 2, 3, 3, 1, 4], "B": data_for_grouping}) result = df.groupby("A").B.apply(lambda x: x.array) diff --git a/pandas/tests/extension/test_boolean.py b/pandas/tests/extension/test_boolean.py index 3ef3beaa9c1b1..89991a459795e 100644 --- a/pandas/tests/extension/test_boolean.py +++ b/pandas/tests/extension/test_boolean.py @@ -16,6 +16,8 @@ import numpy as np import pytest +from pandas.compat.numpy import is_numpy_dev + import pandas as pd import pandas._testing as tm from pandas.core.arrays.boolean import BooleanDtype @@ -320,6 +322,7 @@ def test_groupby_extension_apply(self, data_for_grouping, groupby_apply_op): df.groupby("A").apply(groupby_apply_op) df.groupby("A").B.apply(groupby_apply_op) + @pytest.mark.xfail(is_numpy_dev, reason="2021-03-02 #40144 expecting fix in numpy") def test_groupby_apply_identity(self, data_for_grouping): df = pd.DataFrame({"A": [1, 1, 2, 2, 3, 3, 1], "B": data_for_grouping}) result = df.groupby("A").B.apply(lambda x: x.array) From fa2732c5be4b61e7d4de657c28e417f372545f83 Mon Sep 17 00:00:00 2001 From: Brock Date: Tue, 2 Mar 2021 18:53:44 -0800 Subject: [PATCH 2/2] xfail strict=False --- pandas/tests/extension/base/groupby.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pandas/tests/extension/base/groupby.py b/pandas/tests/extension/base/groupby.py index 7a40a5360156a..d93afef60561a 100644 --- a/pandas/tests/extension/base/groupby.py +++ b/pandas/tests/extension/base/groupby.py @@ -75,7 +75,10 @@ def test_groupby_extension_apply(self, data_for_grouping, groupby_apply_op): df.groupby("A").apply(groupby_apply_op) df.groupby("A").B.apply(groupby_apply_op) - @pytest.mark.xfail(is_numpy_dev, reason="2021-03-02 #40144 expecting fix in numpy") + # Non-strict bc these xpass on dt64tz, Period, Interval, JSON, PandasArray + @pytest.mark.xfail( + is_numpy_dev, reason="2021-03-02 #40144 expecting fix in numpy", strict=False + ) def test_groupby_apply_identity(self, data_for_grouping): df = pd.DataFrame({"A": [1, 1, 2, 2, 3, 3, 1, 4], "B": data_for_grouping}) result = df.groupby("A").B.apply(lambda x: x.array)