Skip to content

Fix bug on master #38987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2021
Merged

Fix bug on master #38987

merged 2 commits into from
Jan 6, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 6, 2021 •
edited
Loading

  • Ensure all linting tests pass, see here for how to run them

The banklist file was removed and replaced with banklist.csv. This causes failures on master.

This is just a temporary fix for the user guide.

cc @jreback

jreback
jreback approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u open an issue to replace those xfailed tests with another public file

lgtm ping on green

@jreback jreback added this to the 1.2.1 milestone Jan 6, 2021
@jreback jreback added Testing pandas testing functions or related to the test suite CI Continuous Integration IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Jan 6, 2021
@phofl phofl mentioned this pull request Jan 6, 2021
Closed
@jreback jreback merged commit 68db2d2 into pandas-dev:master Jan 6, 2021
@jreback
Copy link
Contributor

jreback commented Jan 6, 2021

thanks for fixing @phofl

@jreback
Copy link
Contributor

jreback commented Jan 6, 2021

@meeseeksdev backport 1.2.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 6, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 6, 2021
@phofl @meeseeksmachine
Backport PR pandas-dev#38987: Fix bug on master
aa9cd65
@phofl phofl deleted the bug_on_master branch January 6, 2021 02:53
simonjayhawkins pushed a commit that referenced this pull request Jan 6, 2021
@meeseeksmachine @phofl
Backport PR #38987: Fix bug on master (#38991)
3dd9561 
Co-authored-by: patrick <[email protected]>
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@phofl @luckyvs1
Fix bug on master (pandas-dev#38987)
2e2400c 
* Fix bug on master

* Fix indent problem
lithomas1 added a commit to lithomas1/pandas that referenced this pull request Aug 4, 2021
@lithomas1
Revert "Fix bug on master (pandas-dev#38987)"
85bc22a 
This reverts commit 68db2d2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jreback