DOC: Add datatest package to list of third-party extension accessors. #38593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what to make of this. The changes I made don't seem to be an issue according to the "Build documentation" logs:
The successful build used Sphinx v3.3.1 and the failing build used Sphinx v3.4.0. In the successful build, there are warnings emitted after the success. But in the failing build, these same warnings are emitted during the process--causing it to fail. EDIT: Correction, there are additional warnings in the failing build that aren't in the passing build (see following comment). |
|
This seems to be happening for files totally unrelated to the change. The failing Build documentation step emits warnings that the passing build did not. This seems to have started with the newly published Sphinx v3.4.0 (released earlier today). The new warnings are as follows: |
|
Here's the changelog for Sphinx 3.4.0: https://www.sphinx-doc.org/en/master/changes.html#release-3-4-0-released-dec-20-2020 |
|
e should pin sphinx to the earlier version want to do a PR? |
Sure. I'll post in a minute. |
|
thanks @shawnbrown |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
datatestpackage to the list of third-party extension accessors. Sincedatatestsupports more thanpandas, I wasn't sure if it was appropriate to add it to the Data cleaning and validation section, so I only added it to the accessors list for now.Unfortunately, the "Classes" column was not wide enough--so this patch affects all rows in the table. This shouldn't happen again as the column is now wide enough to accommodate all of the classes that support extension accessors.