BUG: Allow numeric ExtensionDtypes in DataFrame.select_dtypes #38246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
changed the title
5 tasks
jreback
requested changes
Dec 3, 2020
pandas/core/frame.py
Outdated
| if issubclass( | ||
| unique_dtype.type, tuple(dtypes_set) # type: ignore[arg-type] | ||
| ) | ||
| if np_issubclass_compat(unique_dtype, dtypes_set) |
There was a problem hiding this comment.
i don't think we need to create yet another method here. is there a reason you cannot just use something like
return issubclass(unique_dtype.type, tuple(dtypes_set)) or (
np.number in dtypes_set and is_numeric_dtype(unique_dtype))
)
There was a problem hiding this comment.
Having now tried this I think the reason might be mypy
pandas/core/frame.py:3715: error: Argument 1 to "tuple" has incompatible type "FrozenSet[Union[ExtensionDtype, str, Any, Type[str], Type[float], Type[int], Type[complex], Type[bool], Type[object]]]"; expected "Iterable[Union[type, Tuple[Any, ...]]]" [arg-type]
There was a problem hiding this comment.
Reverted to having a separate method
There was a problem hiding this comment.
just ignore mypy here, this makes groking the code way more complicated.
jreback
added
Dtype Conversions
jreback
requested changes
Dec 13, 2020
pandas/core/frame.py
Outdated
| ) | ||
| or ( | ||
| np.number in dtypes_set | ||
| and hasattr(unique_dtype, "_is_numeric") # is an extensionarray |
There was a problem hiding this comment.
can u check is_extension_array_dtype here instead
|
Green + addressed comments |
jreback
requested changes
Dec 14, 2020
pandas/core/frame.py
Outdated
| or ( | ||
| np.number in dtypes_set | ||
| and is_extension_array_dtype(unique_dtype) | ||
| and unique_dtype._is_numeric |
There was a problem hiding this comment.
use getattr(unique_dtype, '_is_numeric', False) as we don't actually require this on an EA type (maybe we should though)
| is_selected = df.select_dtypes(np.number).shape == df.shape | ||
| assert is_selected == expected | ||
|
|
||
| # da = DummyArray([1, 2], dtype=DummyDtype(numeric=False)) |
|
Green + addressed comments |
jreback
approved these changes
Dec 14, 2020
|
thanks @arw2019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffPicking up #35341 (original PR addressed all comments - here I merged master + added whatsnew note)
cc @simonjayhawkins @jreback @jbrockmendel