ENH: make closed part of IntervalDtype #37933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Dtype Conversions
|
updated to fix doctests, raise on mismatched 'closed'. still not wild about how we're handling old pickles, and ATM still allowing closed=None to be passed to the constructor |
|
mothballing to clear the queue while i figure out the pickle thing locally. |
jbrockmendel
added
the
Mothballed
jbrockmendel
removed
the
Mothballed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffcc @jschendel
Still need to figure out what to do for backwards compat for unpickled IntervalDtype objects; ATM this just sets closed=None.
This causes IntervalIndex.append to cast to object dtype instead of raising if we try to append a non-matching closed. I think thats the right thing to do, but we haven't fully discussed that xref #37774