From ee7a7ba93e7b7519bcfa90160b911851a6c31d8e Mon Sep 17 00:00:00 2001 From: jnecus Date: Tue, 13 Oct 2020 11:32:14 +0100 Subject: [PATCH 1/4] Update code_checks.sh --- ci/code_checks.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ci/code_checks.sh b/ci/code_checks.sh index 784d2c9a411ab..fbab6be213b4b 100755 --- a/ci/code_checks.sh +++ b/ci/code_checks.sh @@ -292,6 +292,10 @@ if mods: " RET=$(($RET + $?)) ; echo $MSG "DONE" + MSG='Check code for instances of os.remove' ; echo $MSG + invgrep -R --include="*.py*" --exclude "common.py" "test_writers.py" -E "os.remove" pandas/tests/ + RET=$(($RET + $?)) ; echo $MSG "DONE" + fi ### DOCTESTS ### From c553d1160135ea353fa83f54c152095c3e718c55 Mon Sep 17 00:00:00 2001 From: jnecus Date: Tue, 13 Oct 2020 14:29:45 +0100 Subject: [PATCH 2/4] Update code_checks.sh Passed files to be excluded from search as seperate arguments --- ci/code_checks.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/code_checks.sh b/ci/code_checks.sh index fbab6be213b4b..bd327956ea33b 100755 --- a/ci/code_checks.sh +++ b/ci/code_checks.sh @@ -293,7 +293,7 @@ if mods: RET=$(($RET + $?)) ; echo $MSG "DONE" MSG='Check code for instances of os.remove' ; echo $MSG - invgrep -R --include="*.py*" --exclude "common.py" "test_writers.py" -E "os.remove" pandas/tests/ + invgrep -R --include="*.py*" --exclude "common.py" --exclude "test_writers.py" --exclude "test_store.py" -E "os.remove" pandas/tests/ RET=$(($RET + $?)) ; echo $MSG "DONE" fi From fa820cde7778990f3c25b4f2a55a6a319de6b6c8 Mon Sep 17 00:00:00 2001 From: jnecus Date: Wed, 14 Oct 2020 11:46:32 +0100 Subject: [PATCH 3/4] Update code_checks.sh escaped "\" in os.remove --- ci/code_checks.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/code_checks.sh b/ci/code_checks.sh index bd327956ea33b..e9a6453ff493a 100755 --- a/ci/code_checks.sh +++ b/ci/code_checks.sh @@ -293,7 +293,7 @@ if mods: RET=$(($RET + $?)) ; echo $MSG "DONE" MSG='Check code for instances of os.remove' ; echo $MSG - invgrep -R --include="*.py*" --exclude "common.py" --exclude "test_writers.py" --exclude "test_store.py" -E "os.remove" pandas/tests/ + invgrep -R --include="*.py*" --exclude "common.py" --exclude "test_writers.py" --exclude "test_store.py" -E "os\.remove" pandas/tests/ RET=$(($RET + $?)) ; echo $MSG "DONE" fi From aee1a9e51276cf9df695f81061f5f60c0056f368 Mon Sep 17 00:00:00 2001 From: jnecus Date: Wed, 14 Oct 2020 12:43:37 +0100 Subject: [PATCH 4/4] Update code_checks.sh --- ci/code_checks.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ci/code_checks.sh b/ci/code_checks.sh index e9a6453ff493a..5437692d54439 100755 --- a/ci/code_checks.sh +++ b/ci/code_checks.sh @@ -268,6 +268,10 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then invgrep -RI --exclude=\*.{svg,c,cpp,html,js} --exclude-dir=env "\s$" * RET=$(($RET + $?)) ; echo $MSG "DONE" unset INVGREP_APPEND + + MSG='Check code for instances of os.remove' ; echo $MSG + invgrep -R --include="*.py*" --exclude "common.py" --exclude "test_writers.py" --exclude "test_store.py" -E "os\.remove" pandas/tests/ + RET=$(($RET + $?)) ; echo $MSG "DONE" fi ### CODE ### @@ -292,10 +296,6 @@ if mods: " RET=$(($RET + $?)) ; echo $MSG "DONE" - MSG='Check code for instances of os.remove' ; echo $MSG - invgrep -R --include="*.py*" --exclude "common.py" --exclude "test_writers.py" --exclude "test_store.py" -E "os\.remove" pandas/tests/ - RET=$(($RET + $?)) ; echo $MSG "DONE" - fi ### DOCTESTS ###