From 1b0bd0cfeee6931500f58cf1c5cdcc5c7c1280a2 Mon Sep 17 00:00:00 2001 From: Brock Date: Mon, 28 Sep 2020 09:08:20 -0700 Subject: [PATCH 1/3] npdev fix --- pandas/tests/arithmetic/common.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pandas/tests/arithmetic/common.py b/pandas/tests/arithmetic/common.py index 755fbd0d9036c..128eb6734506a 100644 --- a/pandas/tests/arithmetic/common.py +++ b/pandas/tests/arithmetic/common.py @@ -76,6 +76,13 @@ def assert_invalid_comparison(left, right, box): "Cannot compare type", "not supported between", "invalid type promotion", + ( + # GH#?? npdev 1.20.0 2020-09-28 + r"The DTypes and " + r" do not have a common DType. " + "For example they cannot be stored in a single array unless the " + "dtype is `object`." + ), ] ) with pytest.raises(TypeError, match=msg): From 844fca6eda7ec80f55706c0f1cf76f3df30dad0f Mon Sep 17 00:00:00 2001 From: Brock Date: Mon, 28 Sep 2020 09:09:09 -0700 Subject: [PATCH 2/3] gh ref --- pandas/tests/arithmetic/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/arithmetic/common.py b/pandas/tests/arithmetic/common.py index 128eb6734506a..cd8dd102dc27c 100644 --- a/pandas/tests/arithmetic/common.py +++ b/pandas/tests/arithmetic/common.py @@ -77,7 +77,7 @@ def assert_invalid_comparison(left, right, box): "not supported between", "invalid type promotion", ( - # GH#?? npdev 1.20.0 2020-09-28 + # GH#36706 npdev 1.20.0 2020-09-28 r"The DTypes and " r" do not have a common DType. " "For example they cannot be stored in a single array unless the " From 6107c438463b0f742549757cabb5cc19d4905683 Mon Sep 17 00:00:00 2001 From: Brock Date: Mon, 28 Sep 2020 09:34:09 -0700 Subject: [PATCH 3/3] catch message --- pandas/tests/frame/test_arithmetic.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pandas/tests/frame/test_arithmetic.py b/pandas/tests/frame/test_arithmetic.py index 6dd8d890e8a4b..b3aa5e403e795 100644 --- a/pandas/tests/frame/test_arithmetic.py +++ b/pandas/tests/frame/test_arithmetic.py @@ -53,6 +53,11 @@ def check(df, df2): msgs = [ r"Invalid comparison between dtype=datetime64\[ns\] and ndarray", "invalid type promotion", + ( + # npdev 1.20.0 + r"The DTypes and " + r" do not have a common DType." + ), ] msg = "|".join(msgs) with pytest.raises(TypeError, match=msg):