From ad684713a74a58f841c652e59e312e93df14d76e Mon Sep 17 00:00:00 2001 From: Wesley Date: Fri, 25 Sep 2020 14:29:34 +0200 Subject: [PATCH 1/3] TST: GH 32431 check print label indexing on nan --- pandas/tests/indexing/test_indexing.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pandas/tests/indexing/test_indexing.py b/pandas/tests/indexing/test_indexing.py index 0cc61cd7df389..39e01dd69e121 100644 --- a/pandas/tests/indexing/test_indexing.py +++ b/pandas/tests/indexing/test_indexing.py @@ -868,6 +868,13 @@ def test_no_reference_cycle(self): del df assert wr() is None + def test_label_indexing_on_nan(self): + # GH 32431 + df = pd.Series([1, "{1,2}", 1, None]) + vc = df.value_counts(dropna=False) + print(vc.loc[np.nan]) + print(vc[np.nan]) + class TestSeriesNoneCoercion: EXPECTED_RESULTS = [ From 89a274f0537a0d221dec2390bfde2071cc2a89f9 Mon Sep 17 00:00:00 2001 From: Wesley Date: Fri, 25 Sep 2020 19:39:50 +0200 Subject: [PATCH 2/3] TST: GH 32431 added assert to check print label indexing on nan --- pandas/tests/indexing/test_indexing.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pandas/tests/indexing/test_indexing.py b/pandas/tests/indexing/test_indexing.py index 39e01dd69e121..79459eaa8d8c7 100644 --- a/pandas/tests/indexing/test_indexing.py +++ b/pandas/tests/indexing/test_indexing.py @@ -872,8 +872,12 @@ def test_label_indexing_on_nan(self): # GH 32431 df = pd.Series([1, "{1,2}", 1, None]) vc = df.value_counts(dropna=False) - print(vc.loc[np.nan]) - print(vc[np.nan]) + result1 = vc.loc[np.nan] + result2 = vc[np.nan] + + expected = 1 + assert result1 == expected + assert result2 == expected class TestSeriesNoneCoercion: From 2b6b2cfcdc4e8cbb03aad8d383eb654696f0664d Mon Sep 17 00:00:00 2001 From: Simon Hawkins Date: Thu, 12 Nov 2020 14:21:35 +0000 Subject: [PATCH 3/3] pd.Series -> Series --- pandas/tests/indexing/test_indexing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/indexing/test_indexing.py b/pandas/tests/indexing/test_indexing.py index 68928f9f6ed3f..ae5bf783e9d8a 100644 --- a/pandas/tests/indexing/test_indexing.py +++ b/pandas/tests/indexing/test_indexing.py @@ -831,7 +831,7 @@ def test_no_reference_cycle(self): def test_label_indexing_on_nan(self): # GH 32431 - df = pd.Series([1, "{1,2}", 1, None]) + df = Series([1, "{1,2}", 1, None]) vc = df.value_counts(dropna=False) result1 = vc.loc[np.nan] result2 = vc[np.nan]