Skip to content

CLN: Update files (as per #36450) to Python 3.7+ syntax #36457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

CLN: Update files (as per #36450) to Python 3.7+ syntax #36457

merged 1 commit into from
Sep 18, 2020

Conversation

ahgamut
Copy link
Contributor

@ahgamut ahgamut commented Sep 18, 2020

Ran pyupgrade on all files unchecked in #36450. formatter pre-commit
hook had no complaints; removed unnecessary imports from the following
to satisfy flake8 hook:

pandas/tests/io/test_sql.py
pandas/test/series/test_io.py

@ahgamut
CLN: Update files (as per pandas-dev#36450) to Python 3.7+ syntax
eb3e43f 
Ran pyupgrade on all files unchecked in pandas-dev#36450. formatter pre-commit
hook had no complaints; removed unnecessary imports from the following
to satisfy flake8 hook:

pandas/tests/io/test_sql.py
pandas/test/series/test_io.py
@ahgamut ahgamut mentioned this pull request Sep 18, 2020
Closed
54 tasks
MarcoGorelli
MarcoGorelli approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This changes loads of files, but most of the changes are so minor I think it's OK

@MarcoGorelli MarcoGorelli mentioned this pull request Sep 18, 2020
Closed
WillAyd
WillAyd approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't aware of this tool - pretty cool.

I think the CI failure is unrelated - just restarted let's see

@WillAyd WillAyd added the Code Style Code style, linting, code_checks label Sep 18, 2020
@WillAyd WillAyd added this to the 1.2 milestone Sep 18, 2020
@jreback jreback merged commit 4caafd4 into pandas-dev:master Sep 18, 2020
@jreback
Copy link
Contributor

jreback commented Sep 18, 2020

thanks @ahgamut very nice!

@ahgamut ahgamut deleted the style-py37 branch September 19, 2020 16:48
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@ahgamut
CLN: Update files (as per pandas-dev#36450) to Python 3.7+ syntax (pa…
5461b9a 
…ndas-dev#36457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

CLN upgrade to Python3.7+ syntax
4 participants
@ahgamut @jreback @WillAyd @MarcoGorelli