From f1ee4573fc6aeb57eac6e5705495bbb4d00c31e2 Mon Sep 17 00:00:00 2001
From: Simon Hawkins <simonjayhawkins@gmail.com>
Date: Mon, 31 Aug 2020 13:32:09 +0100
Subject: [PATCH] TYP: check_untyped_defs core.internals.concat

---
 pandas/core/internals/concat.py | 19 ++++++++++---------
 setup.cfg                       |  3 ---
 2 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/pandas/core/internals/concat.py b/pandas/core/internals/concat.py
index 99a586f056b12..88839d2211f81 100644
--- a/pandas/core/internals/concat.py
+++ b/pandas/core/internals/concat.py
@@ -1,10 +1,11 @@
 from collections import defaultdict
 import copy
-from typing import List
+from typing import Dict, List
 
 import numpy as np
 
 from pandas._libs import NaT, internals as libinternals
+from pandas._typing import DtypeObj
 from pandas.util._decorators import cache_readonly
 
 from pandas.core.dtypes.cast import maybe_promote
@@ -100,10 +101,10 @@ def _get_mgr_concatenation_plan(mgr, indexers):
     """
     # Calculate post-reindex shape , save for item axis which will be separate
     # for each block anyway.
-    mgr_shape = list(mgr.shape)
+    mgr_shape_list = list(mgr.shape)
     for ax, indexer in indexers.items():
-        mgr_shape[ax] = len(indexer)
-    mgr_shape = tuple(mgr_shape)
+        mgr_shape_list[ax] = len(indexer)
+    mgr_shape = tuple(mgr_shape_list)
 
     if 0 in indexers:
         ax0_indexer = indexers.pop(0)
@@ -126,9 +127,9 @@ def _get_mgr_concatenation_plan(mgr, indexers):
 
         join_unit_indexers = indexers.copy()
 
-        shape = list(mgr_shape)
-        shape[0] = len(placements)
-        shape = tuple(shape)
+        shape_list = list(mgr_shape)
+        shape_list[0] = len(placements)
+        shape = tuple(shape_list)
 
         if blkno == -1:
             unit = JoinUnit(None, shape)
@@ -374,8 +375,8 @@ def _get_empty_dtype_and_na(join_units):
         else:
             dtypes[i] = unit.dtype
 
-    upcast_classes = defaultdict(list)
-    null_upcast_classes = defaultdict(list)
+    upcast_classes: Dict[str, List[DtypeObj]] = defaultdict(list)
+    null_upcast_classes: Dict[str, List[DtypeObj]] = defaultdict(list)
     for dtype, unit in zip(dtypes, join_units):
         if dtype is None:
             continue
diff --git a/setup.cfg b/setup.cfg
index 2ba22e5aad3c7..c10624d60aaff 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -184,9 +184,6 @@ check_untyped_defs=False
 [mypy-pandas.core.internals.blocks]
 check_untyped_defs=False
 
-[mypy-pandas.core.internals.concat]
-check_untyped_defs=False
-
 [mypy-pandas.core.internals.construction]
 check_untyped_defs=False