Skip to content

Fix Series construction from Sparse["datetime64[ns]"] #35838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 27, 2020
Merged

Fix Series construction from Sparse["datetime64[ns]"] #35838

merged 4 commits into from
Aug 27, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Aug 21, 2020 •
edited
Loading

@dsaxton dsaxton added Bug Constructors Series/DataFrame/Index/pd.array Constructors Sparse Sparse Data Type Datetime Datetime data dtype labels Aug 21, 2020
@simonjayhawkins simonjayhawkins mentioned this pull request Aug 21, 2020
Closed
3 tasks
@simonjayhawkins simonjayhawkins added this to the 1.1.2 milestone Aug 25, 2020
@jbrockmendel
Copy link
Member

LGTM

@jreback jreback merged commit d0ca4b3 into pandas-dev:master Aug 27, 2020
@jreback
Copy link
Contributor

jreback commented Aug 27, 2020

thanks @dsaxton

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 27, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 d0ca4b347b060bc4a49b2d31a818d5a28d1e665f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #35838: Fix Series construction from Sparse["datetime64[ns]"]'
  1. Push to a named branch :
git push YOURFORK 1.1.x:auto-backport-of-pr-35838-on-1.1.x
  1. Create a PR against branch 1.1.x, I would have named this PR:

"Backport PR #35838 on branch 1.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@dsaxton dsaxton deleted the sparse-datetime-series-construction branch August 27, 2020 02:29
@dsaxton
Copy link
Member Author

dsaxton commented Aug 27, 2020

Manual backport PR: #35915

@dsaxton dsaxton mentioned this pull request Aug 27, 2020
Merged
simonjayhawkins pushed a commit that referenced this pull request Aug 27, 2020
@dsaxton
"Backport PR #35838 on branch 1.1.x" (#35915)
d7a387b
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@dsaxton
Fix Series construction from Sparse["datetime64[ns]"] (pandas-dev#35838)
725aa72
@simonjayhawkins simonjayhawkins mentioned this pull request Dec 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Bug Constructors Series/DataFrame/Index/pd.array Constructors Datetime Datetime data dtype Sparse Sparse Data Type
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

BUG: Sparse[datetime64[ns]] TypeError: data type not understood
4 participants
@dsaxton @jbrockmendel @jreback @simonjayhawkins