From 47cda29f525d68d380a6a91b54c6b11b08dee069 Mon Sep 17 00:00:00 2001 From: Kilian Date: Fri, 24 Apr 2020 18:32:18 +0200 Subject: [PATCH 1/2] DOC: data_columns can take bool --- pandas/core/generic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/generic.py b/pandas/core/generic.py index 495dcc5700241..2f46ff471ea9e 100644 --- a/pandas/core/generic.py +++ b/pandas/core/generic.py @@ -2359,7 +2359,7 @@ def to_hdf( min_itemsize: Optional[Union[int, Dict[str, int]]] = None, nan_rep=None, dropna: Optional[bool_t] = None, - data_columns: Optional[List[str]] = None, + data_columns: Optional[Union[bool, List[str]]] = None, errors: str = "strict", encoding: str = "UTF-8", ) -> None: From b6e0495f06dfc8c614800ec92dc9279a0d6f1e55 Mon Sep 17 00:00:00 2001 From: Kilian Date: Fri, 24 Apr 2020 19:32:36 +0200 Subject: [PATCH 2/2] Fix specification of bool in type hint --- pandas/core/generic.py | 2 +- pandas/io/pytables.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/core/generic.py b/pandas/core/generic.py index 2f46ff471ea9e..ef058fd0aa074 100644 --- a/pandas/core/generic.py +++ b/pandas/core/generic.py @@ -2359,7 +2359,7 @@ def to_hdf( min_itemsize: Optional[Union[int, Dict[str, int]]] = None, nan_rep=None, dropna: Optional[bool_t] = None, - data_columns: Optional[Union[bool, List[str]]] = None, + data_columns: Optional[Union[bool_t, List[str]]] = None, errors: str = "strict", encoding: str = "UTF-8", ) -> None: diff --git a/pandas/io/pytables.py b/pandas/io/pytables.py index 311d8d0d55341..5845202550326 100644 --- a/pandas/io/pytables.py +++ b/pandas/io/pytables.py @@ -230,7 +230,7 @@ def to_hdf( min_itemsize: Optional[Union[int, Dict[str, int]]] = None, nan_rep=None, dropna: Optional[bool] = None, - data_columns: Optional[List[str]] = None, + data_columns: Optional[Union[bool, List[str]]] = None, errors: str = "strict", encoding: str = "UTF-8", ):