From 3c3bafaf4ae0ea323f754e62ac6e0e9e109f87fb Mon Sep 17 00:00:00 2001 From: jbrockmendel Date: Wed, 18 Mar 2020 16:45:59 -0700 Subject: [PATCH 1/2] use engine_target_valeus --- pandas/core/indexes/base.py | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/pandas/core/indexes/base.py b/pandas/core/indexes/base.py index 162d69d957669..3838fc39dc218 100644 --- a/pandas/core/indexes/base.py +++ b/pandas/core/indexes/base.py @@ -3584,12 +3584,8 @@ def _join_non_unique(self, other, how="left", return_indexers=False): # We only get here if dtypes match assert self.dtype == other.dtype - if is_extension_array_dtype(self.dtype): - lvalues = self._data._values_for_argsort() - rvalues = other._data._values_for_argsort() - else: - lvalues = self._values - rvalues = other._values + lvalues = self._get_engine_target() + rvalues = other._get_engine_target() left_idx, right_idx = _get_join_indexers( [lvalues], [rvalues], how=how, sort=True @@ -3761,12 +3757,8 @@ def _join_monotonic(self, other, how="left", return_indexers=False): else: return ret_index - if is_extension_array_dtype(self.dtype): - sv = self._data._values_for_argsort() - ov = other._data._values_for_argsort() - else: - sv = self._values - ov = other._values + sv = self._get_engine_target() + ov = other._get_engine_target() if self.is_unique and other.is_unique: # We can perform much better than the general case From b78166c440a527c4ae59b710d18fe40be969348e Mon Sep 17 00:00:00 2001 From: jbrockmendel Date: Sat, 18 Apr 2020 16:30:41 -0700 Subject: [PATCH 2/2] remove unnecessary inheritance --- pandas/core/indexes/timedeltas.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/indexes/timedeltas.py b/pandas/core/indexes/timedeltas.py index 3e3591ee42c30..d2e743739db3d 100644 --- a/pandas/core/indexes/timedeltas.py +++ b/pandas/core/indexes/timedeltas.py @@ -51,7 +51,7 @@ ], TimedeltaArray, ) -class TimedeltaIndex(DatetimeTimedeltaMixin, dtl.TimelikeOps): +class TimedeltaIndex(DatetimeTimedeltaMixin): """ Immutable ndarray of timedelta64 data, represented internally as int64, and which can be boxed to timedelta objects.