TST: make tests stricter #32527
TST: make tests stricter #32527
Conversation
pandas/tests/io/json/test_ujson.py
Outdated
| if numpy is None or orient == "index": | ||
| dtype = np.int64 | ||
| if numpy is True and orient is None: | ||
| dtype = np.int64 |
There was a problem hiding this comment.
@WillAyd do these conditional dtypes make sense? i was surprised that the windows special-casing was needed
There was a problem hiding this comment.
I think this is related to #28560 which I closed since we deprecated the numpy argument. Are you seeing this issue generally on Windows?
There was a problem hiding this comment.
this was necessary to get the CI passing. i havent run any other windows builds
There was a problem hiding this comment.
are you OK with these being here like this? maybe a comment about them being made unnecessary at some point?
There was a problem hiding this comment.
Can you refactor this to start with np.int64 and only special case the 32 bit needs? I think that would make it more logical to follow / clean up whenever that argument is removed
There was a problem hiding this comment.
you can make this a fixture as well
pandas/tests/io/json/test_ujson.py
Outdated
| if numpy is None or orient == "index": | ||
| dtype = np.int64 | ||
| if numpy is True and orient is None: | ||
| dtype = np.int64 |
There was a problem hiding this comment.
you can make this a fixture as well
|
thanks |
I expect to see some platform-specific failures, will be nice to document those where possible.