Skip to content

DOC release notes add assert_frame_equal checks index and column names #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2013
Merged

DOC release notes add assert_frame_equal checks index and column names #3174

merged 1 commit into from
Mar 25, 2013
+2 −1

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Mar 25, 2013

Appended to release notes re #2964.
I put it in "API changes" (not sure if that is optimal but I wasn't sure where else it would fit).

@jreback
Copy link
Contributor

jreback commented Mar 25, 2013

hold off on merging for just a bit

going to put up a PR to fix index name propagation

so @hayd u might be able to some of the checks back on

@hayd
Copy link
Contributor Author

hayd commented Mar 25, 2013

This PR is just a DOC update and only changes release.rst.

Excellent to your PR, there are a few index/column name bugs/features to work through. Let me know which you are hitting and perhaps I can help on some others.

Weirdly, travis is broken on LOCALE build (presumably it is in master too):

FAIL: test_to_csv_moar (pandas.tests.test_frame.TestDataFrame)

@hayd
Copy link
Contributor Author

hayd commented Mar 25, 2013

@y-p I think it's one of your last commits fails on travis. (Or did you just fix it?)

@ghost
Copy link

ghost commented Mar 25, 2013

I think it's been there for a while and just didn't register. I just added
slow tests to LOCALE_OVERRIDE a couple of days ago on jeff's prompting.
Pretty sure I just pushed a fix for it 5 minutes ago, skipping some tests
until #3173 gets merged. float precision issues.

hayd added a commit that referenced this pull request Mar 25, 2013
@hayd
Merge pull request #3174 from hayd/assert-frame-equal-doc
fe438e9 
DOC release notes add assert_frame_equal checks index and column names
@hayd hayd merged commit fe438e9 into pandas-dev:master Mar 25, 2013
@hayd hayd deleted the assert-frame-equal-doc branch March 25, 2013 19:36
@hayd hayd mentioned this pull request Mar 25, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayd @jreback