Skip to content

REF: remove last major pytables state-altering #30372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 26, 2019

Conversation

jbrockmendel
Copy link
Member

Mentioned in #30344.

@jbrockmendel jbrockmendel added the IO HDF5 read_hdf, HDFStore label Dec 20, 2019
obj : DataFrame
The object to create axes on.
validate: bool, default True
Whethr to validate the obj against an existing object already written.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether

@jreback jreback added this to the 1.0 milestone Dec 20, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, comments


Parameters
----------
axes: a list of the axes in order to create (names or numbers of the axes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you edit these to be proper doc-strings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formalized it to the extent I could. A lot of these docstrings could use improvement

@jreback jreback merged commit 3ece097 into pandas-dev:master Dec 26, 2019
@jreback
Copy link
Contributor

jreback commented Dec 26, 2019

thanks

@jbrockmendel jbrockmendel deleted the ref-pytables-state branch December 26, 2019 01:11
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants