From 979e05c4d71968a9e9e409e492bbe2bdb01e47fd Mon Sep 17 00:00:00 2001 From: jbrockmendel Date: Wed, 18 Dec 2019 09:34:17 -0800 Subject: [PATCH] TST: follow-up ot #30318 --- pandas/core/groupby/ops.py | 5 +---- pandas/tests/extension/base/getitem.py | 7 +++++++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/pandas/core/groupby/ops.py b/pandas/core/groupby/ops.py index fa8e4985090a7..f123a5265bb0d 100644 --- a/pandas/core/groupby/ops.py +++ b/pandas/core/groupby/ops.py @@ -663,10 +663,7 @@ def _aggregate_series_pure_python(self, obj: Series, func): if len(res) == 1: # e.g. test_agg_lambda_with_timezone lambda e: e.head(1) # FIXME: are we potentially losing import res.index info? - - # TODO: use `.item()` if/when we un-deprecate it. - # For non-Series we could just do `res[0]` - res = next(iter(res)) + res = res.item() else: raise ValueError("Function does not reduce") result = np.empty(ngroups, dtype="O") diff --git a/pandas/tests/extension/base/getitem.py b/pandas/tests/extension/base/getitem.py index 0e4a86ed44529..71c7fbb986267 100644 --- a/pandas/tests/extension/base/getitem.py +++ b/pandas/tests/extension/base/getitem.py @@ -272,3 +272,10 @@ def test_item(self, data): s = pd.Series(data) result = s[:1].item() assert result == data[0] + + msg = "can only convert an array of size 1 to a Python scalar" + with pytest.raises(ValueError, match=msg): + s[:0].item() + + with pytest.raises(ValueError, match=msg): + s.item()