From 2596bbd8ae10a822df7a983327193e564ce2fb48 Mon Sep 17 00:00:00 2001 From: farziengineer Date: Sun, 20 Oct 2019 00:37:07 +0530 Subject: [PATCH 1/2] Added code to check if file exists for read_json. --- pandas/io/json/_json.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pandas/io/json/_json.py b/pandas/io/json/_json.py index 6ce288890b6c7..e71e695e5a5a5 100644 --- a/pandas/io/json/_json.py +++ b/pandas/io/json/_json.py @@ -1,4 +1,5 @@ from collections import OrderedDict +from errno import ENOENT from io import StringIO from itertools import islice import os @@ -708,6 +709,14 @@ def _get_data_from_filepath(self, filepath_or_buffer): ) self.should_close = True self.open_stream = data + else: + raise FileNotFoundError( + ENOENT, + "File {filepath_or_buffer} does not exist".format( + filepath_or_buffer=filepath_or_buffer + ), + filepath_or_buffer, + ) return data From 1a6c53848b45719a48b5643bb38e6808c182dbba Mon Sep 17 00:00:00 2001 From: tadashigaki Date: Sat, 26 Oct 2019 02:29:36 +0900 Subject: [PATCH 2/2] change error type in read_json tests --- pandas/tests/io/test_common.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/tests/io/test_common.py b/pandas/tests/io/test_common.py index 655fd9d01c1c0..1938f5f994db5 100644 --- a/pandas/tests/io/test_common.py +++ b/pandas/tests/io/test_common.py @@ -141,7 +141,7 @@ def test_iterator(self): (pd.read_hdf, "tables", FileNotFoundError, "h5"), (pd.read_stata, "os", FileNotFoundError, "dta"), (pd.read_sas, "os", FileNotFoundError, "sas7bdat"), - (pd.read_json, "os", ValueError, "json"), + (pd.read_json, "os", FileNotFoundError, "json"), (pd.read_msgpack, "os", FileNotFoundError, "mp"), (pd.read_pickle, "os", FileNotFoundError, "pickle"), ], @@ -176,7 +176,7 @@ def test_read_non_existant(self, reader, module, error_class, fn_ext): (pd.read_hdf, "tables", FileNotFoundError, "h5"), (pd.read_stata, "os", FileNotFoundError, "dta"), (pd.read_sas, "os", FileNotFoundError, "sas7bdat"), - (pd.read_json, "os", ValueError, "json"), + (pd.read_json, "os", FileNotFoundError, "json"), (pd.read_msgpack, "os", FileNotFoundError, "mp"), (pd.read_pickle, "os", FileNotFoundError, "pickle"), ],