Added Engine Disposal Documentation #27972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poojahagawane
force-pushed
the
23086-engine-disposal-docs
branch
from
9aa0b10 to
0561adc
Compare
gfyoung
reviewed
Aug 18, 2019
| or DBAPI2 connection (fallback mode) | ||
| Using SQLAlchemy makes it possible to use any DB supported by that | ||
| library. Legacy support is provided for sqlite3.Connection objects. | ||
| Note: The user is responsible for engine disposal and connection |
There was a problem hiding this comment.
Suggested change
| Note: The user is responsible for engine disposal and connection | |
| Note: The user is responsible for engine disposal and connection |
There was a problem hiding this comment.
For these "Note:" sections, let's add a newline above (this applies to your other changes)
There was a problem hiding this comment.
Hey I added the newline however its not rendering in the documentation generated.
There was a problem hiding this comment.
I think they end up in the same paragraph in the generated HTML.
gfyoung
reviewed
Aug 18, 2019
Created hyperlink to SQLAlchemy docs for Engine Disposal responsibilities of user. Unified wording of legacy support for sqlite
poojahagawane
force-pushed
the
23086-engine-disposal-docs
branch
from
a4e7142 to
11f3463
Compare
|
Can you fix merge conflict and address comments? |
jreback
requested changes
Sep 8, 2019
| @@ -72,7 +72,6 @@ I/O | |||
|
|
|||
| - Avoid calling ``S3File.s3`` when reading parquet, as this was removed in s3fs version 0.3.0 (:issue:`27756`) | |||
| - Better error message when a negative header is passed in :func:`pandas.read_csv` (:issue:`27779`) | |||
| - Follow the ``min_rows`` display option (introduced in v0.25.0) correctly in the HTML repr in the notebook (:issue:`27991`). | |||
|
can you merge master and revert the 0.25.1 file |
|
Nice idea but looks like this has gone stale so closing; ping if you'd like to pick this back up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created hyperlink to SQLAlchemy docs for Engine Disposal
responsibilities of user. Unified wording of legacy support for sqlite
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff