TST: handle inconsistent ordering in resample_api compat test #27196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should fix the 3.5 occasionally failing tests |
TomAugspurger
approved these changes
Jul 3, 2019
| @@ -247,7 +247,7 @@ def test_agg_consistency(): | |||
| check_stacklevel=False): | |||
| expected = r[['A', 'B', 'C']].agg({'r1': 'mean', 'r2': 'sum'}) | |||
| result = r.agg({'r1': 'mean', 'r2': 'sum'}) | |||
| assert_frame_equal(result, expected) | |||
| assert_frame_equal(result, expected, check_like=True) | |||
There was a problem hiding this comment.
LGTM. This could maybe be check_like=not compat.PY36 so that we continue to check it for 3.6 and above. But I suspect we have other tests ensuring the order.
There was a problem hiding this comment.
yeah just saw a bunch of failures here.
There was a problem hiding this comment.
Yeah, I think ideally we should only do this for py 3.5
yep, I pinned < 5.0 on the 3.6 builds (already pinned on 3.5); so I think this is ok. will merge and rebase other that looks ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.