From 905f7b817e63a07a8b42dbdd77f2c9b6ab199dc4 Mon Sep 17 00:00:00 2001 From: James Myatt Date: Tue, 18 Dec 2018 11:07:03 +0000 Subject: [PATCH 1/2] DOC: Update compiler guidance for Windows --- doc/source/contributing.rst | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/doc/source/contributing.rst b/doc/source/contributing.rst index b88f0d3c33fc7..97b13df610dae 100644 --- a/doc/source/contributing.rst +++ b/doc/source/contributing.rst @@ -125,7 +125,7 @@ requires a C compiler and Python environment. If you're making documentation changes, you can skip to :ref:`contributing.documentation` but you won't be able to build the documentation locally before pushing your changes. -.. _contributiong.dev_c: +.. _contributing.dev_c: Installing a C Compiler ~~~~~~~~~~~~~~~~~~~~~~~ @@ -133,13 +133,16 @@ Installing a C Compiler Pandas uses C extensions (mostly written using Cython) to speed up certain operations. To install pandas from source, you need to compile these C extensions, which means you need a C compiler. This process depends on which -platform you're using. Follow the `CPython contributing guidelines -`_ for getting a +platform you're using. Follow the `CPython contributing guide +`_ for getting a compiler installed. You don't need to do any of the ``./configure`` or ``make`` steps; you only need to install the compiler. For Windows developers, the following links may be helpful. +* **TL;DR** (Python 3.5+) install `Visual Studio 2017 `_, select + the **Python development workload** and the **Python native development tools** option +* https://blogs.msdn.microsoft.com/pythonengineering/2017/03/07/python-support-in-vs2017/ * https://blogs.msdn.microsoft.com/pythonengineering/2016/04/11/unable-to-find-vcvarsall-bat/ * https://github.com/conda/conda-recipes/wiki/Building-from-Source-on-Windows-32-bit-and-64-bit * https://cowboyprogrammer.org/building-python-wheels-for-windows/ @@ -149,7 +152,7 @@ For Windows developers, the following links may be helpful. Let us know if you have any difficulties by opening an issue or reaching out on `Gitter`_. -.. _contributiong.dev_python: +.. _contributing.dev_python: Creating a Python Environment ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ From 6a999aff2136c6aeaf34d6974b807b57601eaec5 Mon Sep 17 00:00:00 2001 From: James Myatt Date: Tue, 18 Dec 2018 12:03:57 +0000 Subject: [PATCH 2/2] Move TLDR --- doc/source/contributing.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/source/contributing.rst b/doc/source/contributing.rst index 97b13df610dae..281dbd72db161 100644 --- a/doc/source/contributing.rst +++ b/doc/source/contributing.rst @@ -138,10 +138,11 @@ platform you're using. Follow the `CPython contributing guide compiler installed. You don't need to do any of the ``./configure`` or ``make`` steps; you only need to install the compiler. -For Windows developers, the following links may be helpful. +For Windows developers, when using Python 3.5 and later, it is sufficient to +install `Visual Studio 2017 `_ with the +**Python development workload** and the **Python native development tools** +option. Otherwise, the following links may be helpful. -* **TL;DR** (Python 3.5+) install `Visual Studio 2017 `_, select - the **Python development workload** and the **Python native development tools** option * https://blogs.msdn.microsoft.com/pythonengineering/2017/03/07/python-support-in-vs2017/ * https://blogs.msdn.microsoft.com/pythonengineering/2016/04/11/unable-to-find-vcvarsall-bat/ * https://github.com/conda/conda-recipes/wiki/Building-from-Source-on-Windows-32-bit-and-64-bit