BUG: Throw ValueError when the format kwarg is passed to the HDFStore… #24155
Conversation
|
Hello @CianciuStyles! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #24155 +/- ##
==========================================
+ Coverage 92.2% 92.2% +<.01%
==========================================
Files 162 162
Lines 51700 51702 +2
==========================================
+ Hits 47670 47672 +2
Misses 4030 4030
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24155 +/- ##
==========================================
+ Coverage 92.21% 92.21% +<.01%
==========================================
Files 162 162
Lines 51721 51723 +2
==========================================
+ Hits 47692 47694 +2
Misses 4029 4029
Continue to review full report at Codecov.
|
doc/source/whatsnew/v0.24.0.rst
Outdated
| @@ -1492,6 +1492,7 @@ Notice how we now instead output ``np.nan`` itself instead of a stringified form | |||
| - Bug in :func:`DataFrame.to_string()` that broke column alignment when ``index=False`` and width of first column's values is greater than the width of first column's header (:issue:`16839`, :issue:`13032`) | |||
| - Bug in :func:`DataFrame.to_string()` that caused representations of :class:`DataFrame` to not take up the whole window (:issue:`22984`) | |||
| - Bug in :func:`DataFrame.to_csv` where a single level MultiIndex incorrectly wrote a tuple. Now just the value of the index is written (:issue:`19589`). | |||
| - :func:`HDFStore` will throw ``ValueError`` when the ``format`` kwarg is passed to the constructor (:issue:`13291`) | |||
|
looks ok, ping when pushed / green. |
CianciuStyles
force-pushed
the
fix-issue-13291
branch
from
3359cfd to
fedddcf
Compare
|
lgtm. ping on green. |
|
Hello Jeff, it looks like everything is green now. |
|
thans @CianciuStyles |
… constructor
git diff upstream/master -u -- "*.py" | flake8 --diff