Skip to content

Fix build by removing flake8-rst #23975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix build by removing flake8-rst #23975

wants to merge 1 commit into from

Conversation

datapythonista
Copy link
Member

@datapythonista datapythonista commented Nov 28, 2018 •
edited
Loading

Seems like flake8-rst==0.4.2 is not available in conda anymore. This is making the Travis build fail. Newer versions of flake8-rst are not usable yet, as they validate more things than 0.4.2 and validating our docs would fail the CI too.

We're working on fixing all the flake8-rst linting problems in the docs, and soon we'll be able to upgrade to a newer version. But for now, I think removing flake8-rst from the dependencies, and disabling the docs validation in the CI is the best, so Travis builds pass again.

CC: @jreback @FHaase

@datapythonista datapythonista added CI Continuous Integration Dependencies Required and optional dependencies labels Nov 28, 2018
@codecov
Copy link

codecov bot commented Nov 28, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@30c1290). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #23975   +/-   ##
=========================================
  Coverage          ?   92.31%           
=========================================
  Files             ?      161           
  Lines             ?    51473           
  Branches          ?        0           
=========================================
  Hits              ?    47517           
  Misses            ?     3956           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.7% <ø> (?)
#single 42.43% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c1290...4402cb1. Read the comment docs.

@FHaase
Copy link
Contributor

FHaase commented Nov 28, 2018

I think we could upgrade flake8-rst and exclude all files that throw errors.

Then we could reactivate it file by file.

@FHaase
Copy link
Contributor

FHaase commented Nov 28, 2018

So if #23847 could be merged I'd rather merge that.

@TomAugspurger
Copy link
Contributor

Why isn't it available anymore? Was it previously coming through the conda-forge channel?

@FHaase
Copy link
Contributor

FHaase commented Nov 28, 2018

Yes. It still shows 0.4.2 in the files section.

@TomAugspurger
Copy link
Contributor

This shouldn't be necessary anymore. Anaconda is in the process of switching how conda-forge packages are being mirrored.

Follow https://gitter.im/conda-forge/conda-forge.github.io for updates.

@jreback
Copy link
Contributor

jreback commented Nov 28, 2018

latest build seems ok.

@jreback
Copy link
Contributor

jreback commented Nov 28, 2018

migth have been temporary?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Nov 28, 2018 via email

@saurav2608 saurav2608 mentioned this pull request Nov 29, 2018
Merged
4 tasks
@datapythonista
Copy link
Member Author

I'm still having some problems with travis, it's timing out when creating the environment that has all the linting stuff. But closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datapythonista @FHaase @TomAugspurger @jreback